Skip to content

Add AssemblyScript as a dependency when using asinit #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dguo
Copy link

@dguo dguo commented Oct 19, 2019

When I followed the quick start guide, I ended up with a package.json with no dependencies even though the guide says package.json will have AssemblyScript as a development dependency after running npx asinit ..

It may also be worth amending the guide to recommend running npm init before npm install --save-dev AssemblyScript/assemblyscript.

@dguo dguo force-pushed the patch-1 branch 2 times, most recently from 1b9494b to a243469 Compare October 19, 2019 22:06
@dguo dguo mentioned this pull request Oct 20, 2019
@MaxGraey
Copy link
Member

This already fixed in master

@dcodeIO
Copy link
Member

dcodeIO commented Nov 17, 2019

Is it?

@MaxGraey
Copy link
Member

MaxGraey commented Nov 17, 2019

Sorry, not yet. @dcodeIO could we merge this? If solve conflicts

@dcodeIO
Copy link
Member

dcodeIO commented Nov 17, 2019

Looks like with the recent npm changes, asinit should obtain the version of the compiler from __dirname + "/../package.json" and insert it as "assemblyscript": VERSION. In case of a nightly, the version should be exact I think, and otherwise be preceeded by a ^.

Still wondering how to deal with development installs. Might make sense to use a direct file link in this case.

@dcodeIO dcodeIO mentioned this pull request Nov 30, 2019
@dcodeIO dcodeIO closed this in #982 Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants