devlib: Use async Target API

Make use of the new async API to speedup other parts of devlib.

Author: douglas-raillard-arm

devlib/collector/ftrace.py

@@ -28,6 +28,7 @@
 from devlib.host import PACKAGE_BIN_DIRECTORY
 from devlib.exception import TargetStableError, HostError
 from devlib.utils.misc import check_output, which, memoized
+from devlib.utils.asyn import asyncf
 
 
 TRACE_MARKER_START = 'TRACE_MARKER_START'
@@ -224,7 +225,8 @@ def reset(self):
             self.target.write_value(self.function_profile_file, 0, verify=False)
         self._reset_needed = False
 
-    def start(self):
+    @asyncf
+    async def start(self):
         self.start_time = time.time()
         if self._reset_needed:
             self.reset()
@@ -263,14 +265,17 @@ def start(self):
             self.target.cpuidle.perturb_cpus()
         # Enable kernel function profiling
         if self.functions and self.tracer is None:
-            self.target.execute('echo nop > {}'.format(self.current_tracer_file),
-                                as_root=True)
-            self.target.execute('echo 0 > {}'.format(self.function_profile_file),
-                                as_root=True)
-            self.target.execute('echo {} > {}'.format(self.function_string, self.ftrace_filter_file),
-                                as_root=True)
-            self.target.execute('echo 1 > {}'.format(self.function_profile_file),
-                                as_root=True)
+            target = self.target
+            await target.async_manager.concurrently(
+                execute.asyn('echo nop > {}'.format(self.current_tracer_file),
+                                    as_root=True),
+                execute.asyn('echo 0 > {}'.format(self.function_profile_file),
+                                    as_root=True),
+                execute.asyn('echo {} > {}'.format(self.function_string, self.ftrace_filter_file),
+                                    as_root=True),
+                execute.asyn('echo 1 > {}'.format(self.function_profile_file),
+                                    as_root=True),
+            )
 
 
     def stop(self):

devlib/module/cgroups.py

@@ -22,6 +22,7 @@
 from devlib.exception import TargetStableError
 from devlib.utils.misc import list_to_ranges, isiterable
 from devlib.utils.types import boolean
+import devlib.utils.asyn as asyn
 
 
 class Controller(object):
@@ -53,9 +54,10 @@ def __init__(self, kind, hid, clist):
         self.mount_point = None
         self._cgroups = {}
 
-    def mount(self, target, mount_root):
+    @asyn.asyncf
+    async def mount(self, target, mount_root):
 
-        mounted = target.list_file_systems()
+        mounted = await target.list_file_systems.asyn()
         if self.mount_name in [e.device for e in mounted]:
             # Identify mount point if controller is already in use
             self.mount_point = [
@@ -66,16 +68,18 @@ def mount(self, target, mount_root):
         else:
             # Mount the controller if not already in use
             self.mount_point = target.path.join(mount_root, self.mount_name)
-            target.execute('mkdir -p {} 2>/dev/null'\
-                    .format(self.mount_point), as_root=True)
-            target.execute('mount -t cgroup -o {} {} {}'\
-                    .format(','.join(self.clist),
-                            self.mount_name,
-                            self.mount_point),
-                            as_root=True)
+            cmd = 'mkdir -p {mount_point} 2>/dev/null && mount -t cgroup -o {clist} {name} {mount_point}'
+            await target.execute.asyn(
+                cmd.format(
+                    clist=','.join(self.clist),
+                    name=self.mount_name,
+                    mount_point=self.mount_point,
+                ),
+                as_root=True,
+            )
 
         # Check if this controller uses "noprefix" option
-        output = target.execute('mount | grep "{} "'.format(self.mount_name))
+        output = await target.execute.asyn('mount | grep "{} "'.format(self.mount_name))
         if 'noprefix' in output:
             self._noprefix = True
             # self.logger.debug('Controller %s using "noprefix" option',
@@ -386,19 +390,30 @@ def __init__(self, target):
         self.logger.debug('Available hierarchies: %s', hierarchy)
 
         # Initialize controllers
-        self.logger.info('Available controllers:')
-        self.controllers = {}
-        for ss in subsys:
+
+        @asyn.asyncf
+        async def init_controller(ss):
             hid = ss.hierarchy
             controller = Controller(ss.name, hid, hierarchy[hid])
             try:
-                controller.mount(self.target, self.cgroup_root)
+                await controller.mount.asyn(self.target, self.cgroup_root)
             except TargetStableError:
                 message = 'Failed to mount "{}" controller'
                 raise TargetStableError(message.format(controller.kind))
             self.logger.info('  %-12s : %s', controller.kind,
                              controller.mount_point)
-            self.controllers[ss.name] = controller
+
+            return controller
+
+        self.logger.info('Available controllers:')
+        controllers = self.target.async_manager.map_concurrently(
+            init_controller,
+            subsys,
+        )
+        self.controllers = {
+            ss.name: controller
+            for ss, controller in controllers.items()
+        }
 
     def list_subsystems(self):
         subsystems = []