-
Notifications
You must be signed in to change notification settings - Fork 985
Three location based - against correct branch #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… than ArjsDeviceOrientationControls
…d where available
|
@kalwalt ok, I think this (new version of #188 against correct branch) is ready to merge - with the understanding that it will only work on Chrome and has only been tested on Android. It is possible to get it to work on Safari/iOS but I think it's probably best that someone with an iPhone, iPad etc. works on that. With that in mind, are you happy for me to merge? With many people having Android devices, which have Chrome by default, it will still be useful and as I said someone can always submit a PR to add iOS/safari support. |
I agree with you. Maybe someone else can submit another PR for iOS devices. |
|
OK, will merge now. |
Referencing correct branch on my repo. See #188 for discussion