Skip to content

Conversation

@nickw1
Copy link
Collaborator

@nickw1 nickw1 commented Oct 19, 2021

Referencing correct branch on my repo. See #188 for discussion

@nickw1 nickw1 mentioned this pull request Oct 19, 2021
@nickw1
Copy link
Collaborator Author

nickw1 commented Oct 19, 2021

@kalwalt ok, I think this (new version of #188 against correct branch) is ready to merge - with the understanding that it will only work on Chrome and has only been tested on Android. It is possible to get it to work on Safari/iOS but I think it's probably best that someone with an iPhone, iPad etc. works on that.

With that in mind, are you happy for me to merge? With many people having Android devices, which have Chrome by default, it will still be useful and as I said someone can always submit a PR to add iOS/safari support.

@kalwalt
Copy link
Member

kalwalt commented Oct 19, 2021

@kalwalt ok, I think this (new version of #188 against correct branch) is ready to merge - with the understanding that it will only work on Chrome and has only been tested on Android. It is possible to get it to work on Safari/iOS but I think it's probably best that someone with an iPhone, iPad etc. works on that.

With that in mind, are you happy for me to merge? With many people having Android devices, which have Chrome by default, it will still be useful and as I said someone can always submit a PR to add iOS/safari support.

I agree with you. Maybe someone else can submit another PR for iOS devices.

@nickw1
Copy link
Collaborator Author

nickw1 commented Oct 19, 2021

OK, will merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants