Skip to content

Commit 0ea8de2

Browse files
authored
Do not use lower tag names to find releases/tags (go-gitea#29261)
Fix go-gitea#26090, see go-gitea#26090 (comment) Since `TagName` stores the original tag name and `LowerTagName` stores the lower tag name, it doesn't make sense to use lowercase tags as `TagNames` in `FindReleasesOptions`. https://github.com/go-gitea/gitea/blob/5e72526da4e915791f03af056890e16821bde052/services/repository/push.go#L396-L397 While the only other usage looks correct: https://github.com/go-gitea/gitea/blob/5e72526da4e915791f03af056890e16821bde052/routers/web/repo/repo.go#L416
1 parent 5e72526 commit 0ea8de2

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

services/repository/push.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -321,14 +321,9 @@ func pushUpdateAddTags(ctx context.Context, repo *repo_model.Repository, gitRepo
321321
return nil
322322
}
323323

324-
lowerTags := make([]string, 0, len(tags))
325-
for _, tag := range tags {
326-
lowerTags = append(lowerTags, strings.ToLower(tag))
327-
}
328-
329324
releases, err := db.Find[repo_model.Release](ctx, repo_model.FindReleasesOptions{
330325
RepoID: repo.ID,
331-
TagNames: lowerTags,
326+
TagNames: tags,
332327
})
333328
if err != nil {
334329
return fmt.Errorf("db.Find[repo_model.Release]: %w", err)
@@ -338,6 +333,11 @@ func pushUpdateAddTags(ctx context.Context, repo *repo_model.Repository, gitRepo
338333
relMap[rel.LowerTagName] = rel
339334
}
340335

336+
lowerTags := make([]string, 0, len(tags))
337+
for _, tag := range tags {
338+
lowerTags = append(lowerTags, strings.ToLower(tag))
339+
}
340+
341341
newReleases := make([]*repo_model.Release, 0, len(lowerTags)-len(relMap))
342342

343343
emailToUser := make(map[string]*user_model.User)

0 commit comments

Comments
 (0)