drivers: dma: siwx917: peripheral req & burst length function changes

- siwx917_is_peripheral_request -> siwx917_transfer_direction
- siwx917_burst_length -> siwx917_is_burst_length_valid
- siwx917_burst_length return type changed to bool
- Added enum for siwx917_transfer_direction return values

Signed-off-by: Sai Santhosh Malae <[email protected]>

Author: smalae

drivers/dma/dma_silabs_siwx91x.c

@@ -21,11 +21,15 @@
 #define DMA_MAX_TRANSFER_COUNT 1024
 #define DMA_CH_PRIORITY_HIGH   1
 #define DMA_CH_PRIORITY_LOW    0
-#define VALID_BURST_LENGTH     0
 #define UDMA_ADDR_INC_NONE     0x03
 
 LOG_MODULE_REGISTER(si91x_dma, CONFIG_DMA_LOG_LEVEL);
 
+enum {
+	TRANSFER_MEM_TO_MEM,
+	TRANSFER_TO_OR_FROM_PER,
+};
+
 struct dma_siwx91x_config {
 	UDMA0_Type *reg;                 /* UDMA register base address */
 	uint8_t channels;                /* UDMA channel count */
@@ -45,17 +49,17 @@ struct dma_siwx91x_data {
 					      */
 };
 
-static int siwx91x_is_peripheral_request(uint32_t dir)
+static int siwx91x_transfer_direction(uint32_t dir)
 {
 	if (dir == MEMORY_TO_MEMORY) {
-		return 0;
+		return TRANSFER_MEM_TO_MEM;
 	}
 
 	if (dir == MEMORY_TO_PERIPHERAL || dir == PERIPHERAL_TO_MEMORY) {
-		return 1;
+		return TRANSFER_TO_OR_FROM_PER;
 	}
 
-	return -1;
+	return -EINVAL;
 }
 
 static int siwx91x_data_width(uint32_t data_width)
@@ -72,13 +76,13 @@ static int siwx91x_data_width(uint32_t data_width)
 	}
 }
 
-static int siwx91x_burst_length(uint32_t blen)
+static bool siwx91x_is_burst_length_valid(uint32_t blen)
 {
 	switch (blen / 8) {
 	case 1:
-		return VALID_BURST_LENGTH; /* 8-bit burst */
+		return true; /* 8-bit burst */
 	default:
-		return -EINVAL;
+		return false;
 	}
 }
 
@@ -112,12 +116,12 @@ static int siwx91x_channel_config(const struct device *dev, RSI_UDMA_HANDLE_T ud
 	RSI_UDMA_CHA_CFG_T channel_config = {};
 	int status;
 
-	if (siwx91x_is_peripheral_request(config->channel_direction) < 0) {
+	if (siwx91x_transfer_direction(config->channel_direction) < 0) {
 		return -EINVAL;
 	}
 
 	channel_config.channelPrioHigh = config->channel_priority;
-	channel_config.periphReq = siwx91x_is_peripheral_request(config->channel_direction);
+	channel_config.periphReq = siwx91x_transfer_direction(config->channel_direction);
 	channel_config.dmaCh = channel;
 
 	if (channel_config.periphReq) {
@@ -140,8 +144,8 @@ static int siwx91x_channel_config(const struct device *dev, RSI_UDMA_HANDLE_T ud
 	    siwx91x_data_width(config->dest_data_size) < 0) {
 		return -EINVAL;
 	}
-	if (siwx91x_burst_length(config->source_burst_length) < 0 ||
-	    siwx91x_burst_length(config->dest_burst_length) < 0) {
+	if (siwx91x_is_burst_length_valid(config->source_burst_length) == false ||
+	    siwx91x_is_burst_length_valid(config->dest_burst_length) == false) {
 		return -EINVAL;
 	}