From 7020bd498572e4fdc231faf40e2f5267b78aea47 Mon Sep 17 00:00:00 2001 From: Hamza Tahir Date: Thu, 9 Nov 2023 23:05:06 +0100 Subject: [PATCH 1/2] Bad PR --- huggingface_sagemaker_deployer/pipelines/promoting.py | 1 - huggingface_sagemaker_deployer/run.py | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/huggingface_sagemaker_deployer/pipelines/promoting.py b/huggingface_sagemaker_deployer/pipelines/promoting.py index 8f57a80..5a39e7e 100644 --- a/huggingface_sagemaker_deployer/pipelines/promoting.py +++ b/huggingface_sagemaker_deployer/pipelines/promoting.py @@ -17,7 +17,6 @@ from zenml import pipeline -from zenml.logger import get_logger from steps import ( notify_on_failure, diff --git a/huggingface_sagemaker_deployer/run.py b/huggingface_sagemaker_deployer/run.py index 120d305..7b48e34 100644 --- a/huggingface_sagemaker_deployer/run.py +++ b/huggingface_sagemaker_deployer/run.py @@ -17,7 +17,7 @@ import os from datetime import datetime as dt -from typing import Optional + import click from zenml.client import Client From cd6c6b77338cdb010fb0a7d468063228c56ae02a Mon Sep 17 00:00:00 2001 From: Hamza Tahir Date: Thu, 9 Nov 2023 23:30:12 +0100 Subject: [PATCH 2/2] Took out old bugs and removed an example docstring --- huggingface_sagemaker_deployer/pipelines/promoting.py | 1 + huggingface_sagemaker_deployer/run.py | 8 +------- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/huggingface_sagemaker_deployer/pipelines/promoting.py b/huggingface_sagemaker_deployer/pipelines/promoting.py index 5a39e7e..8f57a80 100644 --- a/huggingface_sagemaker_deployer/pipelines/promoting.py +++ b/huggingface_sagemaker_deployer/pipelines/promoting.py @@ -17,6 +17,7 @@ from zenml import pipeline +from zenml.logger import get_logger from steps import ( notify_on_failure, diff --git a/huggingface_sagemaker_deployer/run.py b/huggingface_sagemaker_deployer/run.py index 7b48e34..4fcb371 100644 --- a/huggingface_sagemaker_deployer/run.py +++ b/huggingface_sagemaker_deployer/run.py @@ -17,7 +17,7 @@ import os from datetime import datetime as dt - +from typing import Optional import click from zenml.client import Client @@ -59,12 +59,6 @@ # as test set. python run.py --num-epochs 3 --train-batch-size 8 --eval-batch-size 8 - \b - # Run the pipeline with Quality Gate for accuracy set at 90% for train set - # and 85% for test set. If any of accuracies will be lower - pipeline will fail. - python run.py --min-train-accuracy 0.9 --min-test-accuracy 0.85 --fail-on-accuracy-quality-gates - - """ ) @click.option(