From ea7b3337659429bc1fd81c0537d7200e81d2bb3a Mon Sep 17 00:00:00 2001 From: Alex Strick van Linschoten Date: Tue, 25 Nov 2025 10:17:21 +0100 Subject: [PATCH] ci: add testing feedback guidelines to reduce verbosity Adds explicit guidance for Claude Code reviews to keep test suggestions focused and concise. Addresses user feedback that test sections were sometimes verbose or not laser-focused on the specific PR changes. Key changes: - Add dedicated "Testing Feedback Guidelines" section - Prioritize manual testing suggestions over code examples - Limit scope to 1-2 sentence scenarios, not full implementations - Allow skipping test suggestions when not necessary --- .github/workflows/claude-code-review.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml index 64dfc19..3335131 100644 --- a/.github/workflows/claude-code-review.yml +++ b/.github/workflows/claude-code-review.yml @@ -111,9 +111,15 @@ jobs: 6) Constructive Suggestions - Alternative approaches that might be cleaner - Opportunities to reduce complexity - - Missing test coverage for critical component behavior - Opportunities to improve accessibility + Testing Feedback Guidelines: + - **Be concise**: Avoid verbose test suggestions or lengthy code examples. + - **Stay laser-focused**: Only suggest tests that directly verify the specific changes in this PR—not tangential functionality. + - **Prioritize manual testing**: Brief, actionable suggestions for what to manually verify are most useful (e.g., "Test keyboard navigation on the new dropdown"). + - **Limit scope**: If tests are needed, mention the scenario to cover in 1-2 sentences rather than writing full test implementations. + - **Skip if unnecessary**: Not every PR needs test suggestions—if the changes are straightforward or already covered, don't force test recommendations. + Documentation & Storybook Review: - Determine if component behavior, props, or APIs have changed. - Heuristics (run): gh pr diff ${{ github.event.pull_request.number }} --name-only