Skip to content

fix: Fix core pull request workflow #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025
Merged

fix: Fix core pull request workflow #444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a97c89
Update to latest triton release version
yinggeh Jul 10, 2025
360af32
fsafa
yinggeh Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
apt update
apt install -y --no-install-recommends clang-format-15 cmake libb64-dev rapidjson-dev libre2-dev
wget -O /tmp/boost.tar.gz https://archives.boost.io/release/1.80.0/source/boost_1_80_0.tar.gz && (cd /tmp && tar xzf boost.tar.gz) && mv /tmp/boost_1_80_0/boost /usr/include/boost && rm /tmp/boost.tar.gz
pip install build pytest
pip install build pytest pytest-asyncio
Copy link
Contributor

@pranavm-nvidia pranavm-nvidia Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this was working before? Were the async tests added newly? In that case why didn't CI fail on the PR that introduced them?

Copy link
Contributor Author

@yinggeh yinggeh Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explained in the description. Maybe a recent version reports async def functions are not natively supported as error which used to be just warnings.


- name: Build
run: |
Expand Down