From cc1c850bd5616cbee2168015a982e5be3d62a100 Mon Sep 17 00:00:00 2001 From: Aaryaman Vasishta Date: Tue, 4 May 2021 23:16:11 +0900 Subject: [PATCH] Update comment of square_to_spherical_coordinates to reflect extra dim Hello there! I found a small mistake in the doc of this square_to_spherical_coordinates. It returns [:,:,3] whereas the doc says [:,:,2], so did a quick fix there. If there's any other way you'd prefer this change, please let me know. Thanks! --- tensorflow_graphics/math/math_helpers.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tensorflow_graphics/math/math_helpers.py b/tensorflow_graphics/math/math_helpers.py index f58fab324..5b2666feb 100644 --- a/tensorflow_graphics/math/math_helpers.py +++ b/tensorflow_graphics/math/math_helpers.py @@ -170,8 +170,8 @@ def square_to_spherical_coordinates(point_2d, "math_square_to_spherical_coordinates". Returns: - A tensor of shape `[A1, ..., An, 2]` with [..., 0] having values in - [0.0, pi] and [..., 1] with values in [0.0, 2pi]. + A tensor of shape `[A1, ..., An, 3]` with [..., 1] having values in + [0.0, pi] and [..., 2] with values in [0.0, 2pi]. Raises: ValueError: if the shape of `point_2d` is not supported.