Force charset to utf8mb4 and utf8mb4_unicode_ci charset/collation #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cflipse
reviewed
Sep 15, 2025
| adapter: trilogy | ||
| encoding: utf8mb4 # <-- forces UTF-8 everywhere | ||
| collation: utf8mb4_unicode_ci # <-- portable across MySQL 5.7/8.0 and MariaDB | ||
| pool: <%= ENV.fetch("RAILS_MAX_THREADS", 5) %> |
There was a problem hiding this comment.
I actually get slightly nervous about making the pool the same size as the rails thread count ... mostly as it's possible that the rails application logic can (potentially) throw things out to their own background threads ...
I'm not really sure just how much this matters, but it's own of those things that makes me :hmmm:
cflipse
reviewed
Sep 15, 2025
| url: <%= ENV.fetch("DATABASE_URL", "trilogy://root@localhost") %> | ||
| default: &default | ||
| adapter: trilogy | ||
| encoding: utf8mb4 # <-- forces UTF-8 everywhere |
cflipse
reviewed
Sep 15, 2025
Comment on lines
+6
to
+7
| user: root | ||
| password: |
There was a problem hiding this comment.
These should either be overridable ... or we should have some documentation in here explicitly pointing towards setting the DATABASE_URL envvar to override with local config. Not everyone knows that's a thing.
|
This pull request has been inactive for 30 days. Please update it or let us know if it is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.