Remove ckeditor gem (#245)

* Remove ckeditor (gh security scan is blocking other work from going through)

* Remove initializer

* Comment out routes and remove spec

* Remove the inclusions from ckeditor asset model

* Quick and dirty commenting/inheritance changes

* Remove inclusion of ckeditor in application.js

Author: maebeale

Gemfile

@@ -32,7 +32,7 @@ gem "will_paginate", "~> 3.1.7"
 gem "bootstrap-will_paginate"
 gem "apipie-rails", "~> 1.5.0"
 gem "rack-cors", require: "rack/cors"
-gem "ckeditor", "~> 4.3.0"
+# gem "ckeditor", "~> 4.3.0" # removed given gh security scan results. still need a replacement.
 gem "binding_of_caller"
 gem "image_processing"
 gem "inky-rb", require: "inky"

Gemfile.lock

@@ -132,9 +132,6 @@ GEM
       rack-test (>= 0.6.3)
       regexp_parser (>= 1.5, < 3.0)
       xpath (~> 3.2)
-    ckeditor (4.3.0)
-      orm_adapter (~> 0.5.0)
-      terrapin
     climate_control (0.2.0)
     cocoon (1.2.15)
     coderay (1.1.3)
@@ -456,7 +453,6 @@ DEPENDENCIES
   brakeman
   bundler-audit
   capybara (~> 3.36)
-  ckeditor (~> 4.3.0)
   cocoon (~> 1.2.6)
   country_select
   debug (~> 1.11)

app/assets/javascripts/application.js

@@ -15,7 +15,7 @@
 //= require bootstrap.min
 //= require cocoon
 //= require annotator-full.min
-//= require ckeditor/init
+
 //= require ckeditor/config
 //= require_tree ./components
 //= require_tree ./select-2

app/models/ckeditor/asset.rb

@@ -1,4 +1,4 @@
 class Ckeditor::Asset < ApplicationRecord
-  include Ckeditor::Orm::ActiveRecord::AssetBase
-  include Ckeditor::Backend::Paperclip
+  # include Ckeditor::Orm::ActiveRecord::AssetBase
+  # include Ckeditor::Backend::Paperclip
 end

app/models/ckeditor/attachment_file.rb

@@ -1,13 +1,13 @@
-class Ckeditor::AttachmentFile < Ckeditor::Asset
-  has_attached_file :data,
-                    :url => "/ckeditor_assets/attachments/:id/:filename",
-                    :path => "/ckeditor_assets/attachments/:id/:filename"
-
-  validates_attachment_presence :data
-  validates_attachment_size :data, :less_than => 100.megabytes
-  do_not_validate_attachment_file_type :data
+class Ckeditor::AttachmentFile < ApplicationRecord # Ckeditor::Asset
+  # has_attached_file :data,
+  #                   :url => "/ckeditor_assets/attachments/:id/:filename",
+  #                   :path => "/ckeditor_assets/attachments/:id/:filename"
+  #
+  # validates_attachment_presence :data
+  # validates_attachment_size :data, :less_than => 100.megabytes
+  # do_not_validate_attachment_file_type :data
 
   def url_thumb
-    @url_thumb ||= Ckeditor::Utils.filethumb(filename)
+    @url_thumb ||= nil # Ckeditor::Utils.filethumb(filename)
   end
 end

app/models/ckeditor/picture.rb

@@ -1,12 +1,12 @@
-class Ckeditor::Picture < Ckeditor::Asset
-  has_attached_file :data,
-                    :url  => "/ckeditor_assets/pictures/:id/:style_:basename.:extension",
-                    :path => "/ckeditor_assets/pictures/:id/:style_:basename.:extension",
-                    :styles => { :content => '800>', :thumb => '118x100#' }
-
-  validates_attachment_presence :data
-  validates_attachment_size :data, :less_than => 2.megabytes
-  validates_attachment_content_type :data, :content_type => /\Aimage/
+class Ckeditor::Picture < ApplicationRecord # Ckeditor::Asset
+  # has_attached_file :data,
+  #                   :url  => "/ckeditor_assets/pictures/:id/:style_:basename.:extension",
+  #                   :path => "/ckeditor_assets/pictures/:id/:style_:basename.:extension",
+  #                   :styles => { :content => '800>', :thumb => '118x100#' }
+  #
+  # validates_attachment_presence :data
+  # validates_attachment_size :data, :less_than => 2.megabytes
+  # validates_attachment_content_type :data, :content_type => /\Aimage/
 
   def url_content
     url(:content)

config/initializers/ckeditor.rb

@@ -1,5 +1,5 @@
 Rails.application.routes.draw do
-  mount Ckeditor::Engine, at: '/admin/ckeditor', as: 'ckeditor'
+  # mount Ckeditor::Engine, at: '/admin/ckeditor', as: 'ckeditor'
   apipie
   get 'cms', to: 'admins/base#show'