Prevent false positives for has children when collections are used

Author: rawilk

src/Components/Inputs/CustomSelectOption.php

@@ -84,6 +84,10 @@ public function hasChildren(string $childrenField): bool
             return $this->hasChildren;
         }
 
-        return $this->hasChildren = ! empty($this->optionChildren($childrenField));
+        $children = $this->optionChildren($childrenField);
+
+        return $children instanceof Collection
+            ? $this->hasChildren = $children->isNotEmpty()
+            : $this->hasChildren = ! empty($children);
     }
 }

src/Concerns/GetsSelectOptionProperties.php

@@ -4,6 +4,7 @@
 
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Arr;
+use Illuminate\Support\Collection;
 
 /**
  * @property string $childrenField
@@ -54,7 +55,9 @@ public function optionIsOptGroup($option, ?string $childrenField = null): bool
         // We will consider an option an "opt group" if it has children.
         $children = $this->optionChildren($option, $childrenField);
 
-        return ! empty($children);
+        return $children instanceof Collection
+            ? $children->isNotEmpty()
+            : ! empty($children);
     }
 
     protected function optionProperty($option, $field, $default = null)

tests/Components/Inputs/TreeSelectOptionTest.php

@@ -105,3 +105,26 @@
             });
         });
 });
+
+it('will not show child indicators on empty collections', function () {
+    $option = [
+        'id' => 'foo',
+        'name' => 'Foo',
+        'children' => collect(),
+    ];
+
+    $template = <<<'HTML'
+    <x-tree-select>
+        <x-tree-select-option :value="$option" />
+    </x-tree-select>
+    HTML;
+
+    Route::get('/test', fn () => Blade::render($template, ['option' => $option]));
+
+    get('/test')
+        ->assertElementExists('.tree-select__option-li', function (AssertElement $option) {
+            $option->doesntContain('ul', [
+                'class' => 'tree-select__children',
+            ]);
+        });
+});