Skip to content

Automated Resyntax fixes #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Automated Resyntax fixes #779

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4d7c9a3
Fix 1 occurrence of `make-temporary-directory-migration`
resyntax-ci[bot] Oct 26, 2025
5e1f4b7
Fix 1 occurrence of `nested-when-to-compound-when`
resyntax-ci[bot] Oct 26, 2025
b62a4cc
Fix 2 occurrences of `quasiquote-to-list`
resyntax-ci[bot] Oct 26, 2025
0a97274
Fix 1 occurrence of `inline-unnecessary-begin`
resyntax-ci[bot] Oct 26, 2025
2ab4a07
Fix 7 occurrences of `let-to-define`
resyntax-ci[bot] Oct 26, 2025
18d3b59
Fix 1 occurrence of `map-to-for`
resyntax-ci[bot] Oct 26, 2025
e87e4f9
Fix 1 occurrence of `cond-let-to-cond-define`
resyntax-ci[bot] Oct 26, 2025
c27c4ab
Fix 1 occurrence of `error-to-raise-arguments-error`
resyntax-ci[bot] Oct 26, 2025
d8ee5ff
Fix 2 occurrences of `string-append-with-format-to-format`
resyntax-ci[bot] Oct 26, 2025
1fed9f7
Fix 1 occurrence of `cond-let-to-cond-define`
resyntax-ci[bot] Oct 26, 2025
ded4cf5
Fix 1 occurrence of `map-to-for`
resyntax-ci[bot] Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions drracket-test/tests/drracket/example-tool.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
(define new-collection-root
#;
(string->path "C:\\tmp")
(make-temporary-file "drracket-test-example-tool~a"
'directory))
(make-temporary-directory "drracket-test-example-tool~a"))
(define coll (build-path new-collection-root "coll"))
(unless (directory-exists? coll) (make-directory coll))

Expand Down
12 changes: 5 additions & 7 deletions drracket-test/tests/drracket/no-write-and-frame-leak.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,11 @@ This test checks:
(process-container item)))))

(define (record-shortcut item)
(when (is-a? item selectable-menu-item<%>)
(when (send item get-shortcut)
(define k (append (sort (send item get-shortcut-prefix)
string<=?
#:key symbol->string)
(list (send item get-shortcut))))
(hash-update! shortcuts k (λ (v) (cons (send item get-label) v)) '()))))
(when (and (is-a? item selectable-menu-item<%>) (send item get-shortcut))
(define k
(append (sort (send item get-shortcut-prefix) string<=? #:key symbol->string)
(list (send item get-shortcut))))
(hash-update! shortcuts k (λ (v) (cons (send item get-label) v)) '())))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not digging this change; the and seems harder to read, as does new set of line breaks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line breaks are fmt's doing. As for the when merging, I think I'll try adjusting that rule to only fire if there's three or more nested when forms. That seems more likely to be an improvement when it applies.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've filed jackfirth/resyntax#639 to address this.

(define (get-lab item)
(cond
Expand Down