-
Notifications
You must be signed in to change notification settings - Fork 33
enh(policy): Add discussion of package length #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2521597
2020760
f1fd78c
bbfba1c
589f4f2
8ef6f22
c3c8576
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # The Scope of Packages that pyOpenSci Reviews | ||
| # The Scope of Packages that pyOpenSci Reviews | ||
|
|
||
| The mission of pyOpenSci's open peer review process is to: | ||
|
|
||
|
|
@@ -10,6 +10,7 @@ of Open Source software for those who wish to obtain a Journal paper | |
| through our review. | ||
|
|
||
| ## What types of packages does pyOpenSci review? | ||
|
|
||
| pyOpenSci reviews higher level software packages that support scientific workflows. | ||
|
|
||
| :::{figure-md} fig-target | ||
|
|
@@ -22,7 +23,6 @@ these packages tend to have more variability in long term maintenance and | |
| package infrastructure and quality compared with established core packages. **Source: ["Jupyter meets earth" project](https://jupytearth.org/jupyter-resources/introduction/ecosystem.html)** | ||
| ::: | ||
|
|
||
|
|
||
| :::{admonition} This is a living document | ||
| :class: note | ||
|
|
||
|
|
@@ -49,7 +49,7 @@ data processing and the various stages of managing the | |
| data lifecycle. Packages submitted to pyOpenSci should fit into one or | ||
| more of the categories below and should be within our technical scope. | ||
|
|
||
| ```{admonition} Your Package Does Not Need to Widely Used to be Reviewed | ||
| :::{admonition} Your Package Does Not Need to Widely Used to be Reviewed | ||
| :class: important | ||
|
|
||
| We review packages with the goal of improving package quality and usability for scientists. | ||
|
|
@@ -64,8 +64,7 @@ We welcome young packages that are just entering the scientific Python | |
| ecosystem to apply for review if they are relevant to the science community and | ||
| fit into at least one scope category below. We also welcome mature packages with | ||
| a growing or established community! | ||
| ``` | ||
|
|
||
| ::: | ||
|
|
||
| ## Package categories that are in-scope for pyOpenSci | ||
|
|
||
|
|
@@ -76,13 +75,14 @@ link to or a tutorial that demonstrates its potential application for science. | |
|
|
||
| Below we provide examples of packages from pyOpenSci ecosystem. | ||
|
|
||
| ```{note} | ||
| :::{note} | ||
| Many of the example packages below perform tasks that might fit in multiple | ||
| categories. Examples are there to provide you with a flavor of the types | ||
| of packages that would fall into that category. | ||
| ``` | ||
| ::: | ||
|
|
||
| ### Data retrieval | ||
|
|
||
| Packages for accessing and downloading data from online sources. This category | ||
| includes wrappers for accessing APIs. | ||
|
|
||
|
|
@@ -92,16 +92,15 @@ interest to scientists. However, retrieval packages should be focused on data | |
| sources / topics, rather than services. For example a general client for Amazon | ||
| Web Services data storage would not be in-scope. | ||
|
|
||
| * Examples: [OpenOmics](https://github.com/pyOpenSci/software-submission/issues/31), [pyDov](https://github.com/pyOpenSci/software-submission/issues/19), [Physcraper](https://github.com/pyOpenSci/software-review/issues/26) | ||
|
|
||
| - Examples: [OpenOmics](https://github.com/pyOpenSci/software-submission/issues/31), [pyDov](https://github.com/pyOpenSci/software-submission/issues/19), [Physcraper](https://github.com/pyOpenSci/software-review/issues/26) | ||
|
|
||
| ### Data extraction | ||
|
|
||
| These packages aid in retrieving data from unstructured sources such as text, | ||
| images, and PDFs. They might also parse scientific data types and outputs from | ||
| scientific equipment. | ||
|
|
||
| * Examples: [devicely](https://github.com/pyOpenSci/software-submission/issues/37), [jointly](https://github.com/pyOpenSci/software-submission/issues/45) | ||
| - Examples: [devicely](https://github.com/pyOpenSci/software-submission/issues/37), [jointly](https://github.com/pyOpenSci/software-submission/issues/45) | ||
|
|
||
| ### Data processing and munging | ||
|
|
||
|
|
@@ -110,21 +109,20 @@ category focuses on tools for handling data in specific formats that scientists | |
| may be interested in working with. These data may also be generated from | ||
| scientific workflows or exported from instruments and wearables. | ||
|
|
||
| * Examples: [devicely](https://github.com/pyOpenSci/software-submission/issues/37), [jointly](https://github.com/pyOpenSci/software-submission/issues/45), [MovingPandas](https://github.com/pyOpenSci/software-submission/issues/18), [OpenOmics](https://github.com/pyOpenSci/software-submission/issues/31), [Physcraper](https://github.com/pyOpenSci/software-submission/issues/26) | ||
|
|
||
| - Examples: [devicely](https://github.com/pyOpenSci/software-submission/issues/37), [jointly](https://github.com/pyOpenSci/software-submission/issues/45), [MovingPandas](https://github.com/pyOpenSci/software-submission/issues/18), [OpenOmics](https://github.com/pyOpenSci/software-submission/issues/31), [Physcraper](https://github.com/pyOpenSci/software-submission/issues/26) | ||
|
|
||
| ### Data deposition | ||
|
|
||
| Tools for depositing data into scientific research repositories. | ||
|
|
||
| * Examples: [This is an example from rOpenSci - eml](https://github.com/ropensci/software-review/issues/80) | ||
| - Examples: [This is an example from rOpenSci - eml](https://github.com/ropensci/software-review/issues/80) | ||
|
|
||
| ### Data validation and testing: | ||
|
|
||
| Tools that enable automated validation and checking of data quality and | ||
| completeness. These tools should be able to support scientific workflows. | ||
|
|
||
| * Example: [pandera](https://github.com/pyOpenSci/software-submission/issues/12) | ||
| - Example: [pandera](https://github.com/pyOpenSci/software-submission/issues/12) | ||
|
|
||
| ### Scientific software wrappers | ||
|
|
||
|
|
@@ -139,15 +137,16 @@ We strongly encourage submissions that wrap tools that are open-source with | |
| an OSI-approved license. Exceptions will be evaluated on a case-by-case basis, | ||
| taking into consideration whether open-source options exist. | ||
|
|
||
| * Examples: [PyGMT](https://github.com/pyOpenSci/software-submission/issues/43), [python-graphblas](https://github.com/pyOpenSci/software-submission/issues/81) | ||
| - Examples: [PyGMT](https://github.com/pyOpenSci/software-submission/issues/43), [python-graphblas](https://github.com/pyOpenSci/software-submission/issues/81) | ||
|
|
||
| ### Workflow automation and versioning | ||
|
|
||
| Tools that automate and link together workflows and as such support | ||
| reproducible workflows. These | ||
| tools may include build systems and tools to manage continuous integration. | ||
| This also includes tools that support version control. | ||
|
|
||
| * Examples: Both of these tools are not pyOpenSci reviewed as of yet but are examples of tools that might be in scope for this category - [snakemake](https://snakemake.readthedocs.io/en/stable/), [pyGitHub ](https://github.com/PyGithub/PyGithub) | ||
| - Examples: Both of these tools are not pyOpenSci reviewed as of yet but are examples of tools that might be in scope for this category - [snakemake](https://snakemake.readthedocs.io/en/stable/), [pyGitHub ](https://github.com/PyGithub/PyGithub) | ||
|
|
||
| ### Citation management and bibliometrics: | ||
|
|
||
|
|
@@ -156,17 +155,17 @@ creating CVs or otherwise attributing scientific contributions, or accessing, | |
| manipulating or otherwise working with bibliometric data. (Example: [Example from rOpenSci - RefManageR](https://github.com/ropensci/software-review/issues/119)) | ||
|
|
||
| ### Data visualization and analysis | ||
|
|
||
| These are packages that enhance a scientist's experience in visualizing and | ||
| analyzing data. | ||
|
|
||
| * Examples: [PyGMT - (also spatial and data munging)](https://github.com/pyOpenSci/software-submission/issues/43), | ||
| - Examples: [PyGMT - (also spatial and data munging)](https://github.com/pyOpenSci/software-submission/issues/43), | ||
|
|
||
| ### Database software bindings | ||
|
|
||
| Bindings and wrappers for database APIs. | ||
|
|
||
| * Example: [Example from rOpenSci - rrlite](https://github.com/ropensci/software-review/issues/6) | ||
| Bindings and wrappers for database APIs. | ||
|
|
||
| - Example: [Example from rOpenSci - rrlite](https://github.com/ropensci/software-review/issues/6) | ||
|
|
||
| ## Scope for packages that support analytics, statistics and modeling | ||
|
|
||
|
|
@@ -177,12 +176,12 @@ credible journal. | |
|
|
||
| We consider the following when determining whether an analytics-related package is within our review scope: | ||
|
|
||
| 1. If your package facilitates a scientist using a **known or vetted statistical, AI or Analytical approach** we consider that in-scope. Before submitting to us, please ensure that your package's documentation directs users to existing paper(s) or pre-print(s) that document that approach's application. Further, be sure to link to these publications in your package review submission. | ||
| 1. If your package facilitates a scientist using a **known or vetted statistical, AI or Analytical approach** we consider that in-scope. Before submitting to us, please ensure that your package's documentation directs users to existing paper(s) or pre-print(s) that document that approach's application. Further, be sure to link to these publications in your package review submission. | ||
|
|
||
| The review for this package: | ||
|
|
||
| * requires at least 1 domain specialist | ||
| * will never vet the analytical method itself. | ||
| - requires at least 1 domain specialist | ||
| - will never vet the analytical method itself. | ||
|
|
||
| 2. If your package introduces a novel or newer analytic approach that is not yet vetted/ accepted by a scientific journal, we can not review it. We cannot review projects that exist as a proof-of-concept demonstration of a model or analytical approach that might accompany a paper. In this case, the approach should be sent to a scientific journal for vetting. | ||
|
|
||
|
|
@@ -202,31 +201,76 @@ we will expand this list. | |
|
|
||
| Packages focused on the retrieval, manipulation, and analysis of spatial data. | ||
|
|
||
| * Examples: [PyGmt](https://github.com/pyOpenSci/software-submission/issues/43), | ||
| [Moving Pandas ](https://github.com/pyOpenSci/software-submission/issues/18) | ||
|
|
||
| - Examples: [PyGmt](https://github.com/pyOpenSci/software-submission/issues/43), | ||
| [Moving Pandas ](https://github.com/pyOpenSci/software-submission/issues/18) | ||
|
|
||
| ### Education | ||
|
|
||
| Packages to aid with instruction. | ||
|
|
||
| * Examples: [pyrolite](https://github.com/morganjwilliams/pyrolite) | ||
|
|
||
|
|
||
| - Examples: [pyrolite](https://github.com/morganjwilliams/pyrolite) | ||
|
|
||
| ## Partnerships | ||
|
|
||
| ### Astropy | ||
|
|
||
| We have a [community affiliated package partnership with Astropy](../partners/astropy). To see packages currently under review for Astropy affiliation, visit the [open issues page](https://github.com/pyOpenSci/software-submission/issues?q=is%3Aissue+is%3Aopen) and select the `astropy` label. | ||
|
|
||
| ### Pangeo | ||
|
|
||
| We have a [partnership with Pangeo](../partners/pangeo). Often times packages submitted as a part of that partnership are also in the geospatial domain. | ||
|
|
||
| * Examples: [xclim](https://github.com/pyOpenSci/software-submission/issues/73) | ||
| - Examples: [xclim](https://github.com/pyOpenSci/software-submission/issues/73) | ||
|
|
||
| ## Package technical scope | ||
|
|
||
| (package-size-effort)= | ||
|
|
||
| ### Package size and scholarly effort | ||
lwasser marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| pyOpenSci reviews packages that represent substantial scholarly effort and provide | ||
| meaningful value to the scientific community. While we do not enforce a strict | ||
| minimum line count, we expect packages to demonstrate sufficient complexity and | ||
| functionality to warrant a comprehensive peer review. | ||
|
|
||
| **General expectations:** | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great additions |
||
|
|
||
| - Packages should generally represent at least three months of development work | ||
| for an individual developer | ||
| - We discourage "salami slicing" - breaking up functionality into artificially | ||
| small packages solely to generate multiple submissions | ||
| - Packages with fewer than approximately 1,000 non-comment, non-whitespace lines | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe note that unit tests are not counted toward the 1,000 lines minimum but are expected?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| of code will receive additional scrutiny from editors | ||
| - Note: Unit tests are not counted toward the 1,000 line minimum, but comprehensive | ||
| test coverage is expected for all packages | ||
|
|
||
| **Our approach to smaller packages:** | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice, i like dis |
||
|
|
||
| We recognize that some highly focused, well-designed packages can be extremely | ||
| valuable to the scientific community even with a smaller codebase. If you are | ||
| submitting a package with a smaller codebase, please provide extra detail in your | ||
| submission's landscape analysis section explaining: | ||
|
|
||
| - The previously unmet need your package fills | ||
| - Why this functionality warrants a standalone package | ||
| - The specific scientific workflows it enables | ||
| - How it differs from or complements existing tools | ||
|
|
||
| The final decision on whether a package represents sufficient scholarly effort | ||
| rests with the editor and will be made on a case-by-case basis. | ||
|
|
||
| :::{note} | ||
| **Relationship to JOSS requirements:** | ||
|
|
||
| The Journal of Open Source Software (JOSS) has a [substantial scholarly effort requirement](https://joss.readthedocs.io/en/latest/submitting.html#substantial-scholarly-effort) | ||
| for all submitted packages. While pyOpenSci may review packages that don't meet JOSS's | ||
| minimum requirements, such packages will not be eligible for the fast-track | ||
| JOSS submission process described in our [partnership with JOSS](../partners/joss). | ||
|
|
||
| Our more flexible approach allows us to support useful scientific packages | ||
| that may be outside JOSS scope while maintaining our partnership for | ||
| packages that meet both organizations' criteria. | ||
| ::: | ||
|
|
||
| ### Telemetry & user-informed consent | ||
|
|
||
|
|
@@ -247,29 +291,29 @@ We will evaluate usage data collected by packages on a case-by-case basis | |
| and reserve the right not to review a package if the data collection is overly | ||
| invasive. | ||
|
|
||
|
|
||
| To be in technical scope for a pyOpenSci review, your package: | ||
|
|
||
| * Should have maintenance workflows documented. | ||
| * Should declare vendor dependencies using standard approaches rather than including code from other packages within your repository. | ||
| * Should not have an exceedingly complex structure. Others should be able to contribute and/or take over maintenance if needed. | ||
| - Should have maintenance workflows documented. | ||
| - Should declare vendor dependencies using standard approaches rather than including code from other packages within your repository. | ||
| - Should not have an exceedingly complex structure. Others should be able to contribute and/or take over maintenance if needed. | ||
|
|
||
| ```{admonition} pyOpenSci's goal is to support long(er) term maintenance | ||
| :::{admonition} pyOpenSci's goal is to support long(er) term maintenance | ||
| pyOpenSci has a goal of supporting long term maintenance of open source | ||
| Python tools. It is thus important for us to know that if you need to step down as a maintainer, and that the package infrastructure and documentation is | ||
| in place to support us finding a new maintainer who can take over your | ||
| package's maintenance. | ||
| ``` | ||
| ::: | ||
|
|
||
| ### What if my package seems like its category or domain is out of scope? | ||
|
|
||
| - pyOpenSci is still developing as a community. If your scientific Python | ||
| package does not fit into one of the categories or if you have any other | ||
| questions, we encourage you to open a pre-submission inquiry. We're happy to help. | ||
| package does not fit into one of the categories or if you have any other | ||
| questions, we encourage you to open a pre-submission inquiry. We're happy to help. | ||
| - Data visualization packages come in many varieties, ranging from small | ||
| hyper-specific methods for one type of data to general, do-it-all packages | ||
| (e.g. matplotlib). pyOpenSci accepts packages that are somewhere in between the | ||
| two. If you're interested in submitting your data visualization package, please | ||
| open a pre-submission inquiry first. | ||
| hyper-specific methods for one type of data to general, do-it-all packages | ||
| (e.g. matplotlib). pyOpenSci accepts packages that are somewhere in between the | ||
| two. If you're interested in submitting your data visualization package, please | ||
| open a pre-submission inquiry first. | ||
|
|
||
| ## Examples of packages that might be out of technical scope | ||
|
|
||
|
|
@@ -279,12 +323,14 @@ Your package **may not be in technical scope** for us to review at this time if | |
| it fulfills any of the out-of-technical-scope criteria listed below. | ||
|
|
||
| Your package is in technical scope if it is: | ||
| * Pure Python or Python with built extensions | ||
| * Available from PyPI and/or community conda channels such as conda-forge or bioconda | ||
|
|
||
| - Pure Python or Python with built extensions | ||
| - Available from PyPI and/or community conda channels such as conda-forge or bioconda | ||
|
|
||
| Your package might be out of in technical scope if it is: | ||
| * Not published in a community channel such as PyPI or a channel on anaconda cloud | ||
| * Exceedingly complex in its structure or maintenance needs | ||
|
|
||
| - Not published in a community channel such as PyPI or a channel on anaconda cloud | ||
| - Exceedingly complex in its structure or maintenance needs | ||
|
|
||
| A few examples of packages that may be too technically challenging for us to | ||
| find a new maintainer for in the future are below. | ||
|
|
@@ -312,7 +358,9 @@ maintenance of the original code base to be independent from your package's | |
| maintenance. | ||
|
|
||
| (package-overlap)= | ||
|
|
||
| ## Package Overlap | ||
|
|
||
| pyOpenSci encourages competition among packages, forking and re-implementation | ||
| as they improve options of users. However, we strive to make packages in the | ||
| pyOpenSci suite to represent our top recommendations for the tasks that they | ||
|
|
@@ -324,7 +372,7 @@ being: | |
|
|
||
| - More open in licensing or development practices | ||
| - Broader in functionality (e.g., providing access to more data sets, providing | ||
| a greater suite of functions), but not only by duplicating additional packages | ||
| a greater suite of functions), but not only by duplicating additional packages | ||
| - Better in usability and performance | ||
| - Actively maintained while alternatives are poorly or no longer actively maintained | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,8 +70,18 @@ We offer two pathways for packages previously reviewed by JOSS: | |
| standards. This approach reduces the burden of a full review while ensuring the quality of the package | ||
| reflects its most recent version. | ||
|
|
||
| (coi)= | ||
| :::{note} | ||
| **Submitting to JOSS after pyOpenSci review:** | ||
|
|
||
| While pyOpenSci's scope may be more flexible than JOSS in certain areas (such as | ||
| package size requirements), packages must still meet JOSS's specific criteria to | ||
| be eligible for JOSS fast-track submission. If your package is accepted by pyOpenSci | ||
| but does not meet JOSS requirements (e.g., minimum lines of code), it will not be | ||
| eligible for JOSS fast-track review. See our [package scope guidelines](package-size-effort) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I created this target in the other PR to avoid future broken links. I 'm realizing that we have three pr's here that need to reference each other. 🙃
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might be good to try and push to lower the issue / PR count so we can reduce the overhead of stuff like that (I make mistakes like that all the time too!) |
||
| for more details. | ||
| ::: | ||
|
|
||
| (coi)= | ||
| ## Conflict of interest for reviews and editors | ||
|
|
||
| Following criteria are meant to be a guide for what constitutes a conflict of | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes were made by an autoformatter? Either way, everything in here looks good and should probably add markdown formatting checks to CI.