Table::print_term will now only print colors to terminals #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which raises MSRV to 1.70.0
The practical benefit is that it is now possible to print a colorized table to stderr.
asomers
added a commit
to asomers/prettydiff
that referenced
this pull request
Sep 10, 2023
For example, stderr instead of stdout. Depends on phsym/prettytable-rs#156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The practical benefit is that it is now possible to print a colorized table to stderr.
This PR also replaces is-terminal with std::io::IsTerminal. That raises MSRV to 1.70.