Added validations to reject invalid spec

Author: VershaAgrawal

pkg/validations/backingstore_validations.go

@@ -18,6 +18,34 @@ const (
 
 // ValidateBackingStore validates create validations on resource Backinstore
 func ValidateBackingStore(bs nbv1.BackingStore) error {
+	//Ensure that the Spec contains the expected sub-spec for the declared type
+	switch bs.Spec.Type {
+	case nbv1.StoreTypeAWSS3:
+		if bs.Spec.AWSS3 == nil {
+			return util.ValidationError{Msg: "AWSS3 spec must be provided for type aws-s3"}
+		}
+	case nbv1.StoreTypeS3Compatible:
+		if bs.Spec.S3Compatible == nil {
+			return util.ValidationError{Msg: "S3Compatible spec must be provided for type s3-compatible"}
+		}
+	case nbv1.StoreTypeIBMCos:
+		if bs.Spec.IBMCos == nil {
+			return util.ValidationError{Msg: "IBMCos spec must be provided for type ibm-cos"}
+		}
+	case nbv1.StoreTypeAzureBlob:
+		if bs.Spec.AzureBlob == nil {
+			return util.ValidationError{Msg: "AzureBlob spec must be provided for type azure-blob"}
+		}
+	case nbv1.StoreTypeGoogleCloudStorage:
+		if bs.Spec.GoogleCloudStorage == nil {
+			return util.ValidationError{Msg: "GoogleCloudStorage spec must be provided for type google-cloud-storage"}
+		}
+	case nbv1.StoreTypePVPool:
+		if bs.Spec.PVPool == nil {
+			return util.ValidationError{Msg: "PVPool spec must be provided for type pv-pool"}
+		}
+	}
+
 	if err := ValidateBSEmptySecretName(bs); err != nil {
 		return err
 	}

pkg/validations/namespacestore_validations.go

@@ -19,6 +19,34 @@ const (
 
 // ValidateNamespaceStore validates namespacestore configuration
 func ValidateNamespaceStore(nsStore *nbv1.NamespaceStore) error {
+	// ensure that the Spec contains the expected sub-spec for the declared type
+	switch nsStore.Spec.Type {
+	case nbv1.NSStoreTypeAWSS3:
+		if nsStore.Spec.AWSS3 == nil {
+			return util.ValidationError{Msg: "AWSS3 spec must be provided for type aws-s3"}
+		}
+	case nbv1.NSStoreTypeS3Compatible:
+		if nsStore.Spec.S3Compatible == nil {
+			return util.ValidationError{Msg: "S3Compatible spec must be provided for type s3-compatible"}
+		}
+	case nbv1.NSStoreTypeIBMCos:
+		if nsStore.Spec.IBMCos == nil {
+			return util.ValidationError{Msg: "IBMCos spec must be provided for type ibm-cos"}
+		}
+	case nbv1.NSStoreTypeAzureBlob:
+		if nsStore.Spec.AzureBlob == nil {
+			return util.ValidationError{Msg: "AzureBlob spec must be provided for type azure-blob"}
+		}
+	case nbv1.NSStoreTypeGoogleCloudStorage:
+		if nsStore.Spec.GoogleCloudStorage == nil {
+			return util.ValidationError{Msg: "GoogleCloudStorage spec must be provided for type google-cloud-storage"}
+		}
+	case nbv1.NSStoreTypeNSFS:
+		if nsStore.Spec.NSFS == nil {
+			return util.ValidationError{Msg: "NSFS spec must be provided for type nsfs"}
+		}
+	}
+
 	if err := ValidateNSEmptySecretName(*nsStore); err != nil {
 		return err
 	}