[test] Add device file consistency test

Author: salkinium

modm_devices/device_file.py

@@ -95,7 +95,9 @@ def to_dict(self, t):
                 if children:
                     dd = defaultdict(list)
                     for dc in map(self.to_dict, children):
+                        # print(dc)
                         for k, v in dc.items():
+                            # if k == "signal" and v.get("name") == "seg40": print(v)
                             dd[k].append(v)
                     dk = {}
                     for k, v in dd.items():
@@ -111,8 +113,11 @@ def to_dict(self, t):
                 elif len(attrib):
                     if any(k in d[t.tag] for k in attrib.keys()):
                         raise ParserException("Node children are overwriting attribute '{}'!".format(k))
+                    # print(attrib.items())
                     d[t.tag].update(attrib.items())
                 return read_only({k:read_only(v) for k,v in d.items()})
 
         properties = Converter(identifier).to_dict(self.rootnode.find("device"))
+        # print(properties)
+        # exit(1)
         return properties["device"]

modm_devices/device_identifier.py

@@ -99,12 +99,14 @@ def __init__(self, objs=None):
 
         if isinstance(objs, DeviceIdentifier):
             self._ids = [objs.copy()]
-        if isinstance(objs, (list, set, tuple)):
+        elif isinstance(objs, (list, set, tuple)):
             for obj in objs:
-                if isinstance(objs, DeviceIdentifier):
-                    self._ids.append(objs)
-        if isinstance(objs, MultiDeviceIdentifier):
+                if isinstance(obj, DeviceIdentifier):
+                    self._ids.append(obj)
+        elif isinstance(objs, MultiDeviceIdentifier):
             self._ids = [dev for dev in objs.ids]
+        elif objs is not None:
+            print("No known conversion of '{}' to MultiDeviceIdentifier!".format(objs))
 
     @property
     def ids(self):
@@ -126,13 +128,14 @@ def from_list(device_ids: list):
         mid._ids = [dev for dev in device_ids]
         return mid
 
-    def append(self, did):
-        assert isinstance(did, DeviceIdentifier)
+    def append(self, *dids):
+        for did in dids:
+            assert isinstance(did, DeviceIdentifier)
 
-        self._ids.append(did)
-        self.__dirty = True
-        self.__string = None
-        self.__naming_schema = None
+            self._ids.append(did)
+            self.__dirty = True
+            self.__string = None
+            self.__naming_schema = None
 
     def extend(self, dids):
         assert isinstance(dids, (MultiDeviceIdentifier, list))
@@ -344,4 +347,4 @@ def __str__(self):
         return self.string
 
     def __repr__(self):
-        return self.string
+        return self.string

test/device_file_test.py

@@ -0,0 +1,84 @@
+
+import unittest
+import glob
+import os
+
+import modm_devices.parser
+
+DEVICE_FILES = None
+
+class DeviceFileTest(unittest.TestCase):
+
+    def setUp(self):
+        global DEVICE_FILES
+        if DEVICE_FILES is None:
+            DEVICE_FILES = {}
+            device_files = os.path.join(os.path.dirname(__file__), "../devices/**/*.xml")
+            # device_files = os.path.join(os.path.dirname(__file__), "../devices/stm32/stm32l1-51_52_62-c_d_e.xml")
+            device_file_names  = glob.glob(device_files)
+
+            # Parse the files and build the :target enumeration
+            parser = modm_devices.parser.DeviceParser()
+            for device_file_name in device_file_names:
+                for device in parser.parse(device_file_name).get_devices():
+                    DEVICE_FILES[device.partname] = device
+
+        # self.devices = {"stm32l152vdt6": DEVICE_FILES["stm32l152vdt6"]}
+        self.devices = DEVICE_FILES
+
+
+    def tearDown(self):
+        self.devices = None
+
+    def get_drivers(self, device):
+        drivers = []
+        for d in device._properties["driver"]:
+            if "instance" in d:
+                drivers.extend( (d["name"], i["name"]) for i in d["instance"] )
+            else:
+                drivers.append( (d["name"],) )
+        return drivers
+
+    def test_drivers(self):
+        failures = 0
+        for name, device in self.devices.items():
+            def assertIn(key, obj):
+                if key not in obj:
+                    print('{}: Missing "{}" key in "{}"!'.format(name, key, obj))
+                    nonlocal failures
+                    failures += 1
+                    return False
+                return True
+            drivers = self.get_drivers(device)
+            gpios = device.get_driver("gpio")
+            assertIn("gpio", gpios)
+            for gpio in gpios.get("gpio", []):
+                signals = []
+                for signal in gpio.get("signal", []):
+                    # Check for name and driver keys in each signal
+                    assertIn("name", signal)
+                    if assertIn("driver", signal):
+                        # Check if the signal driver is known
+                        if "instance" in signal:
+                            driver = (signal["driver"], signal["instance"])
+                        else:
+                            driver = (signal["driver"],)
+                        signals.append( (*driver, signal["name"]) )
+                        # assertIn(driver, drivers)
+
+                # Check for duplicate signals
+                if not len(signals) == len(set(signals)):
+                    duplicates = set(x for x in signals if signals.count(x) > 1)
+                    print("{}: duplicated signals for P{}{}: {}".format(
+                            name, gpio["port"].upper(), gpio["pin"], duplicates))
+                    failures += 1
+                    # print(gpio)
+
+        # self.assertEqual(failures, 0, "Found inconsistencies in the device files!")
+
+
+
+
+
+
+