Modify Tester SWI interface for multiple runs #131
+124
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`find_redundant_rules()` is never called. Commented it out and its helper method `find_redundant_rule_`
Address Popper GitHub issue issue 96, "Running Popper from Python in a loop on different scenarios." Handle this by having Popper's `Tester` component conduct its tests in a temporary module, and then destroy that module after running. This prevents name collisions and garbage pile-up between runs of Popper in a single Python process space.
Contributor
Author
|
I've run this MR through all the previous tests, and one new one specifically for multiple runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address Popper GitHub issue #96, "Running Popper from Python in a loop on different scenarios."
Handle this by having Popper's
Testercomponent conduct its tests in a temporary module, and then destroy that module after running. This prevents name collisions and garbage pile-up between runs of Popper in a single Python process space.