fix: prevent canonicalize looping for extremely long time #9030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabianschuiki @seldridge from our discussions on discord. |
A hanging bug can manifest with very large inputs to minimize at canonicalize pass. This is because if the maxNumRewrites is not set, it defaults to kNoLimit, which could be an arbitrary large number. This optional command line argument makes it possible to set the max number of rewrites for large input files to minimize. Signed-off-by: Tianrui Wei <[email protected]>
tianrui-wei
force-pushed
the
dev/tianrui/fix-stuck-canonicalize
branch
from
c180216 to
1895634
Compare
|
Rebased to origin/main, and fixed the CI (hopefully). |
tianrui-wei
force-pushed
the
dev/tianrui/fix-stuck-canonicalize
branch
from
1895634 to
d067963
Compare
|
Ran clang-format and pushed again. |
tianrui-wei
force-pushed
the
dev/tianrui/fix-stuck-canonicalize
branch
from
d067963 to
5f95ee4
Compare
|
Sorry, fixed newer formatting errors... Could you rerun the CI again? :) |
seldridge
approved these changes
Sep 29, 2025
External symbols in the binary will cause problems for static library builds. Switch to using an additional parameter to pass the parameter if it exists. Signed-off-by: Tianrui Wei <[email protected]>
tianrui-wei
force-pushed
the
dev/tianrui/fix-stuck-canonicalize
branch
from
5f95ee4 to
6737163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hanging bug can manifest with very large inputs to minimize at canonicalize pass. This is because if the maxNumRewrites is not set, it defaults to kNoLimit, which could be an arbitrary large number. This optional command line argument makes it possible to set the max number of rewrites for large input files to minimize.