[WIP] JsonSettingsWidgets.py- Simplified monitoring state and improve file operations #12910
+96
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the monitor pause/resume system and replaced it with _is_internal_update flag. Simplified monitoring state - Atomic file operations using temporary files - Safe file replacement with os.replace - Proper file syncing with os.fsync These changes introduce : - Reduced system overhead - Immediate response to changes - Better error handling - Fix CoolerChooser widget issue with real time update in UI in xlet-settings
Hilyxx
changed the title
Improved data management with cleanup of temporary files in the event of an error.
Member
|
Hi, please rebase - I refactored JSONSettingsHandler slightly in 5fd5748 (mainly the file monitor stuff). |
mtwebster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes introduce :
( Colors are not updated in the interface if a 'reset button' is implemented to reset the default values.
The window must be closed and reopened to update the interface due to the high timeout value (2000)