Fix broken models due to modeling/weight mapping #42468
Merged
+184
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
commented
Nov 28, 2025
Member
|
actually needing this for #42456 for jamba + lfm2 |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: lfm2_moe, sam3, sam3_tracker, sam3_tracker_video |
ArthurZucker
approved these changes
Nov 28, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
is it missing a test that can help prevent this?
| ] | ||
| _checkpoint_conversion_mapping = { | ||
| "tracker_model.": "", | ||
| r"tracker_model.(.+)": r"\1", # the regex allows to remove the prefix, and add it back in revert mode |
Member
Author
|
Yes will enforce it with ast later for sure! Along with the |
Sai-Suraj-27
pushed a commit
to Sai-Suraj-27/transformers
that referenced
this pull request
Nov 28, 2025
* lfm2 * fix * config * fixes * fix prefixes * finally * copies * oupsi * rework key renaming * fixes * fix * fix * fix * fix * fix * fix lfm2 * fix * fix more bad mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per the title. A few models got broken in #41580, but it was silent issues on the fast tests.
Mostly discovered in #42396, because the new tests added were not passing for those models, due to the models and not the logic of that PR.