-
Notifications
You must be signed in to change notification settings - Fork 31.3k
[TP plans] Fix some incorrects TP plans #42448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: apertus, doge, nanochat |
| "layers.*.input_layernorm.weight": "sequence_parallel", | ||
| "layers.*.input_residual": "sequence_parallel", | ||
| "layers.*.post_attention_layernorm.weight": "sequence_parallel", | ||
| "layers.*.post_attention_residual": "sequence_parallel", | ||
| "norm.weight": "sequence_parallel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SP is super slow so removed it while I was at it
|
Only a bit weird one is transformers/src/transformers/models/cohere/modular_cohere.py Lines 139 to 146 in 352a2e0
Not sure if we just rep either way but left it for now |
|
Thanks a lot for double checking @vasqu! For cohere, if the main checkpoints do not use the norm, let's not replicate as it's a huge performance drawback! |
What does this PR do?
As per the title. See here for the source
TODO CYRIL: models modified only apply norm on head_dim!! So should be fine without replication. But then nano_chat needs to remove useless replication, and let's check other models with norms to be sure
cc @vasqu