-
-
Notifications
You must be signed in to change notification settings - Fork 275
Fix CI workflows to use Node.js 24.11.1 and resolve type compatibility issues #3025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: renovate/node-24.x
Are you sure you want to change the base?
Conversation
|
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: mrlubos <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## renovate/node-24.x #3025 +/- ##
===================================================
Coverage 33.01% 33.01%
===================================================
Files 426 426
Lines 32792 32792
Branches 2126 2127 +1
===================================================
Hits 10827 10827
Misses 21937 21937
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@copilot CI still failing |
The issue was that @types/node 24.x is incompatible with Node.js 20.x and 22.x in the CI matrix. Using @types/node 20.x ensures compatibility across all tested Node.js versions (20.19.0, 22.12.0, and 24.11.1). Co-authored-by: mrlubos <[email protected]>
Fixed! The CI was failing due to type incompatibilities caused by @types/node 24.x being incompatible with Node.js 20.x and 22.x. I've downgraded @types/node to v20.19.25 to ensure compatibility across all Node.js versions in the CI matrix (20.19.0, 22.12.0, and 24.11.1), and regenerated the pnpm-lock.yaml to resolve the conflicts. (commit 83b50d9) |
The renovate bot updated
.nvmrcto Node.js 24.11.1 but left workflow files referencing 24.10.0, causing CI failures. Additionally, the update to @types/node 24.x caused type incompatibilities with the CI matrix that tests against Node.js 20.x and 22.x.Changes
node-versionmatrix in.github/workflows/ci.ymlfrom24.10.0to24.11.1matrix.node-version == '24.10.0') to use24.11.1in ci.ymlnode-versionin.github/workflows/coverage.ymlto24.11.1node-versionin.github/workflows/release.ymlto24.11.1@types/nodefrom24.10.1to20.19.25to ensure type compatibility across all Node.js versions tested in CI (20.19.0, 22.12.0, and 24.11.1)pnpm-lock.yamlto resolve type conflicts caused by mixed @types/node versionsAll workflow files now align with the Node.js version specified in
.nvmrc, and type checking passes successfully across all tested Node.js versions.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.