Fixes #4004. Driver "windows" broken in conhost and cmd

[BDisp]

Fixes

• Fixes Driver "v2win" broken in conhost #4004

Proposed Changes/Todos

• Add IsVirtualTerminal property to the IApplication interface.

Pull Request checklist:

• I've named my PR in the form of "Fixes #issue. Terse description."
• My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
• My code follows the Terminal.Gui library design guidelines
• I ran dotnet test before commit
• I have made corresponding changes to the API documentation (using /// style comments)
• My changes generate no new warnings
• I have checked my code and corrected any poor grammar or misspellings
• I conducted basic QA to assure all features are working

[BDisp]

The 16 colors are still not rendered very well on selecting ListView, TableView and Menu.

[codecov]

Codecov Report

❌ Patch coverage is 71.87500% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.31%. Comparing base (b9f55a5) to head (c50c8b8).
⚠️ Report is 1 commits behind head on v2_develop.

Files with missing lines	Patch %	Lines
...erminal.Gui/Drivers/WindowsDriver/WindowsOutput.cs	11.42%	25 Missing and 6 partials ⚠️
Terminal.Gui/Drawing/Sixel/SixelSupportDetector.cs	0.00%	0 Missing and 2 partials ⚠️
Terminal.Gui/App/Application.Driver.cs	0.00%	1 Missing ⚠️
Terminal.Gui/Drivers/OutputBase.cs	97.29%	0 Missing and 1 partial ⚠️
Terminal.Gui/Drivers/UnixDriver/UnixOutput.cs	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           v2_develop    #4421       +/-   ##
===============================================
+ Coverage       64.85%   77.31%   +12.45%     
===============================================
  Files             388      388               
  Lines           44984    45054       +70     
  Branches         6343     6354       +11     
===============================================
+ Hits            29176    34835     +5659     
+ Misses          13894     8320     -5574     
+ Partials         1914     1899       -15     

Files with missing lines	Coverage Δ
Terminal.Gui/App/Application.Lifecycle.cs	100.00% <100.00%> (ø)
Terminal.Gui/App/ApplicationImpl.Driver.cs	70.23% <ø> (+18.47%)	⬆️
Terminal.Gui/App/ApplicationImpl.Lifecycle.cs	77.24% <ø> (+3.43%)	⬆️
Terminal.Gui/Drivers/DotNetDriver/NetOutput.cs	65.71% <100.00%> (+65.71%)	⬆️
Terminal.Gui/Drivers/DriverImpl.cs	72.58% <100.00%> (+9.00%)	⬆️
Terminal.Gui/Drivers/FakeDriver/FakeOutput.cs	100.00% <100.00%> (+10.34%)	⬆️
Terminal.Gui/App/Application.Driver.cs	47.05% <0.00%> (-2.95%)	⬇️
Terminal.Gui/Drivers/OutputBase.cs	87.59% <97.29%> (+16.16%)	⬆️
Terminal.Gui/Drivers/UnixDriver/UnixOutput.cs	66.40% <80.00%> (+66.40%)	⬆️
Terminal.Gui/Drawing/Sixel/SixelSupportDetector.cs	94.69% <0.00%> (+64.60%)	⬆️
... and 1 more

... and 160 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 151aa60...c50c8b8. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[BDisp]

The unit test failure is due a some race condition because it pass locally in Windows and Ubuntu.

[tig]

The unit test failure is due a some race condition because it pass locally in Windows and Ubuntu.

I'm confused how you are able to do anything with v2_develop as I broke it pretty completely. 😮

[BDisp]

I'm confused how you are able to do anything with v2_develop as I broke it pretty completely. 😮

There are still many unresolved issues, but the v2_develop branch isn't unusable because I can compile and run it. For example, one problem I'm facing is not being able to test Force16Colors in UICatalog because the CheckBox event isn't triggered when it's clicked. Could you be more specific about why your branch is broken? Do you mean the one from the gui-cs repository or your own?

[tig]

I'm confused how you are able to do anything with v2_develop as I broke it pretty completely. 😮

There are still many unresolved issues, but the v2_develop branch isn't unusable because I can compile and run it. For example, one problem I'm facing is not being able to test Force16Colors in UICatalog because the CheckBox event isn't triggered when it's clicked. Could you be more specific about why your branch is broken? Do you mean the one from the gui-cs repository or your own?

In my case not even UICatalog will run.

I screwed up and the legacy and modern Application concepts are intermixed and thus pretty much everything is broken.

[BDisp]

On my keyboard these tests fails because I need to pass shift as true. So, it depends on keyboard type and the unit tests doesn't get the right keyboard layout. I suggest to comment them to avoid only pass on supported keyboard layouts.