fix: respect --timeout flag for AWS resource deletion waiters #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james00012
force-pushed
the
fix/rds-deletion-timeout-964
branch
2 times, most recently
from
61787b8 to
9658dc2
Compare
james00012
changed the title
james00012
force-pushed
the
fix/rds-deletion-timeout-964
branch
from
9658dc2 to
a552b2b
Compare
james00012
force-pushed
the
fix/rds-deletion-timeout-964
branch
from
521c5c8 to
6c3fcfd
Compare
AWS SDK waiters had hardcoded timeout values that ignored the user-specified --timeout flag. This adds a DefaultWaitTimeout constant (5 minutes) in base_resource.go and sets br.Timeout in PrepareContext. All resources with deletion waiters now use .Timeout instead of hardcoded values. Fixes #964
james00012
force-pushed
the
fix/rds-deletion-timeout-964
branch
from
6c3fcfd to
ba4a484
Compare
denis256
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AWS SDK waiters had hardcoded timeout values that ignored the
--timeoutflag. This PR sets a default timeout inPrepareContextand updates all resources with deletion waiters to use it.Test plan
--timeoutflagFixes #964