From 71ab7f68d5c39ef260f3c30d7788e295ec5c5ee2 Mon Sep 17 00:00:00 2001 From: William Zijie Zhang Date: Wed, 17 Jul 2024 13:03:49 -0700 Subject: [PATCH 1/2] updating python version to 3.9 and readme to have instructions for debugging future errors --- README.md | 4 ++++ pyproject.toml | 2 +- setup.py | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 9a834baab..0937cae64 100644 --- a/README.md +++ b/README.md @@ -13,6 +13,10 @@ Then run the benchmarks against the latest commit on CVXPY by: ``` asv run ``` +Optionally, you can run ``asv dev`` to ensure the code is running smoothly. It is equivalent to the following command: +``` +asv run --python=same --quick --show-stderr --dry-run +``` To run a particular benchmark use: ``` asv run --bench CVaRBenchmark diff --git a/pyproject.toml b/pyproject.toml index bfa998cd4..17b2691b0 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -7,7 +7,7 @@ exclude = [ "*__init__.py" ] # The minimum Python version that should be supported -target-version = "py37" +target-version = "py39" [build-system] requires = ["setuptools>=42"] diff --git a/setup.py b/setup.py index 14c2ce08c..b20cd5a26 100644 --- a/setup.py +++ b/setup.py @@ -15,7 +15,7 @@ }, package_dir={"": "benchmark"}, packages=setuptools.find_packages(where="benchmark"), - python_requires=">=3.7", + python_requires=">=3.9", license='Apache License, Version 2.0', install_requires=[ "cvxpy", From 2cabb00f4e7482d930bf8bab40d92b27c2ef878b Mon Sep 17 00:00:00 2001 From: William Zijie Zhang Date: Wed, 17 Jul 2024 13:12:30 -0700 Subject: [PATCH 2/2] reverting back to 3.8 to pass cvxpy-benchmark builds --- pyproject.toml | 2 +- setup.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 17b2691b0..106c75d75 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -7,7 +7,7 @@ exclude = [ "*__init__.py" ] # The minimum Python version that should be supported -target-version = "py39" +target-version = "py38" [build-system] requires = ["setuptools>=42"] diff --git a/setup.py b/setup.py index b20cd5a26..441cee9b2 100644 --- a/setup.py +++ b/setup.py @@ -15,7 +15,7 @@ }, package_dir={"": "benchmark"}, packages=setuptools.find_packages(where="benchmark"), - python_requires=">=3.9", + python_requires=">=3.8", license='Apache License, Version 2.0', install_requires=[ "cvxpy",