Skip to content

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Dec 2, 2025

Description

remake of #8971


Summary by cubic

Upgrade @modelcontextprotocol/sdk to ^1.24.0 across core and CLI to align with the latest protocol changes and improve stability. Adds small compatibility fixes to MCP prompt role parsing and resource text handling; also bumps AWS Bedrock SDKs and pins vectordb.

  • Bug Fixes

    • Prompt stringification now derives role from content.role or _meta.role, defaulting to assistant.
    • Validate MCP resources include a text field and use resource.text for content.
  • Dependencies

    • @modelcontextprotocol/sdk: ^1.24.0 (ajv v8, ajv-formats, jose, eventsource-parser; zod peer ^3.25 || ^4; zod-to-json-schema ^3.25.0)
    • @aws-sdk/client-bedrock-runtime: ^3.925.0; @aws-sdk/credential-providers: ^3.929.0
    • vectordb: pinned to 0.4.20

Written for commit c8066e6. Summary will update automatically on new commits.

@RomneyDa RomneyDa requested a review from a team as a code owner December 2, 2025 21:47
@RomneyDa RomneyDa requested review from Patrick-Erichsen and removed request for a team December 2, 2025 21:47
@continue
Copy link
Contributor

continue bot commented Dec 2, 2025

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

2 similar comments
@continue-development-app
Copy link

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@continue-development-app
Copy link

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 2, 2025
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

✅ Review Complete

This PR upgrades @modelcontextprotocol/sdk from version 1.12.0/1.17.2 to 1.24.0 and updates related AWS Bedrock SDK dependencies. Here's my review:

Overall Assessment

✅ The changes look clean and focused. This is primarily a dependency upgrade with appropriate version pinning.

Key Changes Reviewed

1. MCP SDK Upgrade (1.12.0 → 1.24.0)

  • New dependencies added: ajv-formats, eventsource-parser, jose
  • Breaking change: Upgraded from ajv v6 to v8
  • New peer dependency: zod is now a required peer dependency (was previously just a dependency)
  • Zod version constraint: Now supports both ^3.25 || ^4.0

Potential Issues:

  • ⚠️ Ajv v6 → v8 migration: This is a major version change that could introduce breaking changes in JSON schema validation. The codebase should be tested to ensure any MCP-related validation still works correctly.
  • ✅ The zod peer dependency requirement is satisfied since the project already uses zod@^3.25.0

2. AWS Bedrock SDK Upgrades

-"@aws-sdk/client-bedrock-runtime": "^3.842.0"
+"@aws-sdk/client-bedrock-runtime": "^3.925.0"
-"@aws-sdk/credential-providers": "^3.913.0"
+"@aws-sdk/credential-providers": "^3.925.0"

✅ These are minor version bumps within the same major version - should be safe.

3. Vectordb Pinning

-"vectordb": "^0.4.20"
+"vectordb": "0.4.20"

✅ Good defensive practice - pinning prevents unexpected updates.

Testing Recommendations

  1. MCP functionality: Test all MCP-related features, especially:

    • MCP server connections
    • MCP context providers
    • OAuth flows (new jose dependency suggests enhanced JWT handling)
  2. Schema validation: Verify any code using MCP SDK's validation (likely using ajv internally)

  3. Bedrock integration: Test AWS Bedrock runtime if used in the codebase

Questions

  • Are there any integration tests covering MCP functionality that can validate this upgrade?
  • Has this been tested against existing MCP servers in use?

Verdict

APPROVE with recommended thorough testing of MCP features due to the ajv major version change.


@continue
Copy link
Contributor

continue bot commented Dec 2, 2025

Reviewed PR #8974 for documentation updates. No documentation changes needed because:

  1. Internal dependency upgrade: This is a routine update of the MCP SDK from 1.12.0/1.17.2 to 1.24.0
  2. Backward compatible: The upgrade maintains compatibility with existing configurations
  3. No user-facing changes: The existing MCP documentation in extensions/cli/spec/mcp.md describes integration architecture, not version-specific features
  4. Automatic benefits: Users automatically benefit from improved stability and new MCP protocol features (Tasks, URL Elicitation, Sampling With Tools) without needing documentation changes

The PR appropriately updates internal dependencies (ajv v8, AWS SDKs, pinned vectordb) without requiring corresponding documentation updates.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 3, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Dec 4, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 4, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 80a33ef into main Dec 4, 2025
56 of 58 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Dec 4, 2025
@Patrick-Erichsen Patrick-Erichsen deleted the dallin/mcp-bump branch December 4, 2025 20:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
@sestinj
Copy link
Contributor

sestinj commented Dec 4, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants