-
Notifications
You must be signed in to change notification settings - Fork 3.9k
chore: mcp 1.24.0 #8974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: mcp 1.24.0 #8974
Conversation
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
2 similar comments
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
|
✅ Review Complete This PR upgrades Overall Assessment✅ The changes look clean and focused. This is primarily a dependency upgrade with appropriate version pinning. Key Changes Reviewed1. MCP SDK Upgrade (1.12.0 → 1.24.0)
Potential Issues:
2. AWS Bedrock SDK Upgrades-"@aws-sdk/client-bedrock-runtime": "^3.842.0"
+"@aws-sdk/client-bedrock-runtime": "^3.925.0"
-"@aws-sdk/credential-providers": "^3.913.0"
+"@aws-sdk/credential-providers": "^3.925.0"✅ These are minor version bumps within the same major version - should be safe. 3. Vectordb Pinning-"vectordb": "^0.4.20"
+"vectordb": "0.4.20"✅ Good defensive practice - pinning prevents unexpected updates. Testing Recommendations
Questions
VerdictAPPROVE with recommended thorough testing of MCP features due to the ajv major version change. |
|
Reviewed PR #8974 for documentation updates. No documentation changes needed because:
The PR appropriately updates internal dependencies (ajv v8, AWS SDKs, pinned vectordb) without requiring corresponding documentation updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 4 files
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
remake of #8971
Summary by cubic
Upgrade @modelcontextprotocol/sdk to ^1.24.0 across core and CLI to align with the latest protocol changes and improve stability. Adds small compatibility fixes to MCP prompt role parsing and resource text handling; also bumps AWS Bedrock SDKs and pins vectordb.
Bug Fixes
Dependencies
Written for commit c8066e6. Summary will update automatically on new commits.