Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Nov 28, 2025

Description

Previously when calling tools in parallel, all tool required approval. This PR changes that behaviour by when calling tools in parallel, the readonly builtin tools which were auto approved get called without waiting.

closes CON-3922

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

before

image

after

image

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Auto-approve and immediately run read-only built-in tools during parallel tool calls. Addresses CON-3922 and removes approval delays and UI flicker for safe built-ins.

  • New Features
    • Auto-exec built-in read-only tools marked allowedWithoutPermission during parallel runs.
    • Filters by BUILT_IN_GROUP_NAME and tool.readonly; dispatches with isAutoApproved: true.
    • Updates stream/UI state to avoid flicker while other tools wait for approval.

Written for commit 2024317. Summary will update automatically on new commits.

@uinstinct uinstinct requested a review from a team as a code owner November 28, 2025 13:28
@uinstinct uinstinct requested review from sestinj and removed request for a team November 28, 2025 13:28
@continue
Copy link
Contributor

continue bot commented Nov 28, 2025

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 28, 2025
@continue
Copy link
Contributor

continue bot commented Nov 28, 2025

Reviewed documentation - no updates needed.

This PR optimizes parallel tool call execution by auto-executing read-only built-in tools immediately rather than waiting for write tool approvals. This is an internal performance improvement that reduces UI flicker and wait times.

The existing documentation in:

  • docs/ide-extensions/agent/how-it-works.mdx
  • docs/ide-extensions/agent/quick-start.mdx
  • docs/ide-extensions/agent/how-to-customize.mdx

Already accurately describes tool permissions and approval behavior at the appropriate level of detail. This optimization doesn't change the user-facing permission model or require any new configuration.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct I think this implementation is really clean, should be good on the thunk side. I noticed a sort-of bug in the screenshot which may or may not be related: it says "Pending 2" calls when it has already called the read only one. Could you check on that?

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Dec 2, 2025
@uinstinct
Copy link
Contributor Author

@uinstinct I think this implementation is really clean, should be good on the thunk side. I noticed a sort-of bug in the screenshot which may or may not be related: it says "Pending 2" calls when it has already called the read only one. Could you check on that?

nice eyes 👀! fixed

image

@uinstinct uinstinct requested a review from RomneyDa December 3, 2025 12:33
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 3, 2025
@RomneyDa RomneyDa merged commit a5ef57a into continuedev:main Dec 3, 2025
51 of 57 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Dec 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2025
@uinstinct uinstinct deleted the approve-read-only branch December 4, 2025 12:26
@sestinj
Copy link
Contributor

sestinj commented Dec 4, 2025

🎉 This PR is included in version 1.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Dec 4, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants