-
Notifications
You must be signed in to change notification settings - Fork 190
feat(core): add resources_scale tool #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
nader-ziada
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, one small question
73c27c4 to
a2cf933
Compare
|
/lgtm |
|
|
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
Co-authored-by: Nader Ziada <[email protected]> Signed-off-by: Calum Murray <[email protected]>
a2cf933 to
a8e3cc4
Compare
|
/run-gevals |
1 similar comment
|
/run-gevals |
Gevals MCP Evaluation ResultsSummary: 0/24 tasks passed (0.0%)
|
Seems like the gevals results are due to inference provider auth issues |
manusa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the gevals improvements (this is a great PR to test its usefulness)
One of the things I do think should be changed is the location of the resources_scale logic to have a clearer separation of concerns.
At the moment, the logic has been placed at the toolsets layer.
However, this layer should only be a wrapper to translate MCP requests into service requests and marshal the service responses appropriately into MCP responses.
Ideally, the scaling logic should be within the pkg/kubernetes module, I'd say that in the resources.go file.
Signed-off-by: Calum Murray <[email protected]>
|
/run-gevals |
|
@manusa I think I fixed the permissions on the key I also moved the scaling logic into |
|
/run-gevals |
Gevals MCP Evaluation ResultsSummary: 21/24 tasks passed (87.5%)
|
|
@manusa the specific scenarios we were targeting here all passed 🎉 On main the scale-* are still failing without this tool: |
Resolves #427
This PR adds support for a
resources_scaletool, so that clients can get and update scale subresources.