handle error message before pipeline run (#273)

handle error message before pipeline run

Author: oren-codefresh

lib/interface/cli/commands/pipeline/run.local.js

@@ -1,3 +1,4 @@
+/* eslint-disable prefer-promise-reject-errors */
 const Docker = require('dockerode');
 const RunBaseCommand = require('./run.base');
 const path = require('path');
@@ -8,6 +9,8 @@ const { log } = require('../../../../logic').api;
 const chalk = require('chalk');
 
 const regex = /##[0-9a-f]{24}##/i;
+const EngineErrorPrefix = 'EngineError';
+
 
 function _customizer(objValue, srcValue) {
     if (Array.isArray(objValue)) {
@@ -39,16 +42,16 @@ class RunLocalCommand extends RunBaseCommand {
         return new Promise((resolve, reject) => {
             this.docker.pull(DEFAULTS.ENGINE_IMAGE, (err, stream) => {
                 if (err) {
-                    console.log(chalk.red(`Failed to update codefresh engine: \n ${err}`));
                     reject(err);
                 }
                 if (stream) {
                     function onFinished(error) {
                         if (error) {
                             reject(error);
+                            return;
                         }
                         console.log('\nFinished Update ==>\n');
-                        resolve(undefined);
+                        resolve();
                     }
 
                     function onProgress(res) {
@@ -105,22 +108,8 @@ class RunLocalCommand extends RunBaseCommand {
         const currentContext = authManager.getCurrentContext();
         console.log(`Running pipeline: ${pipelineName}`);
 
-        process.stdout.on('data', (chunk) => {
-            const line = chunk.toString();
-            const include = line.match(regex);
-            if (include) {
-                const workflowId = include[0].substring(2, include[0].length - 2);
-                log.showWorkflowLogs(workflowId, true)
-                    .then(() => Promise.resolve().then(console.log(`Finished running successfully ${workflowId}`)));
-            }
-        });
-        process.stderr.on('data', (chunk) => {
-            const line = chunk.toString();
-            console.error(`Error occurred while running pipeline with error : ${chalk.red(line)}`);
-            this.status = 'Error';
-        });
         return new Promise((resolve, reject) => {
-            this.docker.run(DEFAULTS.ENGINE_IMAGE, [], undefined, _.mergeWith({
+           const eventEmitter =  this.docker.run(DEFAULTS.ENGINE_IMAGE, [], undefined, _.mergeWith({
                 Env: [
                     `ACCESS_TOKEN=${currentContext.token}`,
                     `PIPELINE_ID=${pipelineName}`, `BRANCH=${branch}`,
@@ -134,20 +123,52 @@ class RunLocalCommand extends RunBaseCommand {
                 },
             }, injectedOpts, _customizer), (err, data) => {
                 if (err) {
-                    console.log(chalk.red(`Errored when running pipeline : ${err}`));
+                    console.log(chalk.red(`Error when running pipeline : ${err}`));
                     // eslint-disable-next-line prefer-promise-reject-errors
-                    reject(1);
+                    resolve(1);
                 }
-            }).on('stream', (stream) => {
+            });
+            if (this.argv.detach) {
+                resolve(0);
+                return;
+            }
+            eventEmitter.on('stream', (stream) => {   
                 stream.on('data', (chunk) => {
                     const line = chunk.toString();
+                    if (line.indexOf(`error: ${EngineErrorPrefix}`) !== -1) {
+                        const error = JSON.parse(line.substring(
+                            line.indexOf(`error: ${EngineErrorPrefix}`) + `error: ${EngineErrorPrefix}`.length,
+                            line.lastIndexOf(EngineErrorPrefix),
+                        ));
+                        if (error.code || error.message) {
+                            console.log(chalk.red(`Error when running pipeline code: ${error.code} message: ${error.message}`));
+                        } else {
+                            console.log(chalk.red(`Error when running pipeline: ${error}`));
+                        }
+                        
+                        this.status = 'Error';
+                        resolve(1);
+                    }
                     const include = line.match(regex);
                     if (include) {
                         const workflowId = include[0].substring(2, include[0].length - 2);
                         log.showWorkflowLogs(workflowId, true)
                             .then(() => resolve(0));
                     }
                 });
+                stream.on('error', (err) => {
+                    if (err) {
+                        console.log(chalk.red(`Pipeline finished with error: ${err}`));
+                        this.status = 'Error';
+                    }
+                    // eslint-disable-next-line prefer-promise-reject-errors
+                    resolve(1);
+                });
+                stream.on('end', () => {
+                    if (this.status !== 'Error') {
+                        resolve(0);
+                    }
+                });
             });
         });
     }