Skip to content

Commit fb16239

Browse files
committed
comment on CLJS-2054 patch subtlety
1 parent 01a1427 commit fb16239

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/main/clojure/cljs/analyzer.cljc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1365,7 +1365,10 @@
13651365
(let [env (if (or (and (not= ns-name 'cljs.core)
13661366
(core-name? env sym))
13671367
(some? (get-in @env/*compiler* [::namespaces ns-name :uses sym])))
1368-
(let [ev (resolve-existing-var (dissoc env :locals) (with-meta sym {::no-resolve true}))
1368+
(let [ev (resolve-existing-var (dissoc env :locals)
1369+
;; ::no-resolve true is to suppress "can't take value
1370+
;; of macro warning" when sym resolves to a macro
1371+
(with-meta sym {::no-resolve true}))
13691372
conj-to-set (fnil conj #{})]
13701373
(when (public-name? (:ns ev) sym)
13711374
(warning :redef env {:sym sym :ns (:ns ev) :ns-name ns-name}))

0 commit comments

Comments
 (0)