-
Notifications
You must be signed in to change notification settings - Fork 106
Fix handling of unexpected arrays in nested described struct fields #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
An automated preview of the documentation is available at https://1129.json.prtest2.cppalliance.org/libs/json/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2025-12-05 14:22:00 UTC |
|
|
|
First, thank you for catching and fixing this. Please, rebase on develop so that CI jobs succeed. |
When parsing unexpected fields containing arrays in described structs, signal_value instead of signal_end to avoid prematurely exiting the parent object context.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1129 +/- ##
===========================================
- Coverage 93.71% 93.67% -0.05%
===========================================
Files 91 91
Lines 9153 9153
===========================================
- Hits 8578 8574 -4
- Misses 575 579 +4
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
|
|
Branch updated, not sure why the coverage dropped -0.05%. |
|
Seems like it's a coverage service bug. I'm discussing dropping that. Bad coverage reports are worse than no coverage reports. |


Fixes a corner case where, when parsing unexpected arrays in nested JSON objects, the
ignoring_handlerwould incorrectly signalsignal_endinstead ofsignal_value, causing the parser to skip the rest of the containing object.