From 925e66706c27cee93df3ffe04a455b7be5745db4 Mon Sep 17 00:00:00 2001 From: Jacob Chung Date: Thu, 4 Dec 2025 16:28:12 -0800 Subject: [PATCH 1/2] telemetry(auth): reenable toolkit_didLoadModule metric --- .../aws/toolkits/jetbrains/services/amazonq/QLoginWebview.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QLoginWebview.kt b/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QLoginWebview.kt index b08c5fb2d83..b8f0a78bec2 100644 --- a/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QLoginWebview.kt +++ b/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QLoginWebview.kt @@ -229,7 +229,7 @@ class QWebviewBrowser(val project: Project, private val parentDisposable: Dispos } is BrowserMessage.PublishWebviewTelemetry -> { -// publishTelemetry(message) + publishTelemetry(message) } is BrowserMessage.OpenUrl -> { From d0af502dfd3e5edd5f830efa5dc3df1b9fdfb8df Mon Sep 17 00:00:00 2001 From: Jacob Chung Date: Thu, 4 Dec 2025 16:30:30 -0800 Subject: [PATCH 2/2] telemetry(auth): reenable toolkit_didLoadModule metric + tests --- .../software/aws/toolkits/jetbrains/core/LoginBrowserTest.kt | 2 -- .../software/aws/toolkits/jetbrains/core/LoginBrowserTest.kt | 2 -- 2 files changed, 4 deletions(-) diff --git a/plugins/core/jetbrains-community/tst-242-252/software/aws/toolkits/jetbrains/core/LoginBrowserTest.kt b/plugins/core/jetbrains-community/tst-242-252/software/aws/toolkits/jetbrains/core/LoginBrowserTest.kt index aa63ddd71d1..2e413651fda 100644 --- a/plugins/core/jetbrains-community/tst-242-252/software/aws/toolkits/jetbrains/core/LoginBrowserTest.kt +++ b/plugins/core/jetbrains-community/tst-242-252/software/aws/toolkits/jetbrains/core/LoginBrowserTest.kt @@ -9,7 +9,6 @@ import com.intellij.ui.jcef.JBCefBrowserBase import com.intellij.ui.jcef.JBCefJSQuery import org.assertj.core.api.Assertions.assertThat import org.junit.jupiter.api.BeforeEach -import org.junit.jupiter.api.Disabled import org.junit.jupiter.api.Test import org.junit.jupiter.api.extension.RegisterExtension import org.mockito.kotlin.argumentCaptor @@ -35,7 +34,6 @@ class TestLoginBrowser(project: Project) : LoginBrowser(project) { override fun loadWebView(query: JBCefJSQuery) {} } -@Disabled class LoginBrowserTest { private lateinit var sut: TestLoginBrowser private val project: Project diff --git a/plugins/core/jetbrains-community/tst-253+/software/aws/toolkits/jetbrains/core/LoginBrowserTest.kt b/plugins/core/jetbrains-community/tst-253+/software/aws/toolkits/jetbrains/core/LoginBrowserTest.kt index 0649bd01280..21cd1ec1ee6 100644 --- a/plugins/core/jetbrains-community/tst-253+/software/aws/toolkits/jetbrains/core/LoginBrowserTest.kt +++ b/plugins/core/jetbrains-community/tst-253+/software/aws/toolkits/jetbrains/core/LoginBrowserTest.kt @@ -8,7 +8,6 @@ import com.intellij.testFramework.HeavyPlatformTestCase import com.intellij.ui.jcef.JBCefBrowserBase import com.intellij.ui.jcef.JBCefJSQuery import org.assertj.core.api.Assertions.assertThat -import org.junit.jupiter.api.Disabled import org.mockito.kotlin.argumentCaptor import org.mockito.kotlin.mock import org.mockito.kotlin.times @@ -31,7 +30,6 @@ class TestLoginBrowser(project: Project) : LoginBrowser(project) { override fun loadWebView(query: JBCefJSQuery) {} } -@Disabled class LoginBrowserTest : HeavyPlatformTestCase() { private lateinit var sut: TestLoginBrowser private val mockTelemetryService = MockTelemetryServiceExtension()