Skip to content

Commit abf0825

Browse files
author
hubert
committed
style: type change
1 parent 1397e09 commit abf0825

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

packages/module-loader/src/createLoader.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import type { ModuleLoader, GetResolver } from './types';
1313
* @param options.resolver remote module resolver, default to umd resolver
1414
* @param options.container container to append script, default is append to body in client side
1515
*/
16-
export function createLoader<Context = any>(
16+
export function createLoader<Props extends Record<string, any> = any, Context = any>(
1717
options: {
1818
resolver?: GetResolver<Context>;
1919
container?: string | ((proxy: Context) => Element);
@@ -24,8 +24,8 @@ export function createLoader<Context = any>(
2424
window.VueDemi = VueDemi;
2525
}
2626

27-
const _resolver = options.resolver?.(options.container) ?? getUmdResolver(options.container as any);
28-
const loader: ModuleLoader = VueDemi.markRaw({
27+
const _resolver = options.resolver?.(options.container) ?? (getUmdResolver(options.container as any) as any);
28+
const loader: ModuleLoader<Props, Context> = VueDemi.markRaw({
2929
install(app) {
3030
// this allows calling registerSubModules() outside of a component setup after
3131
setActiveLoader(loader);

packages/module-loader/src/register.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ let activeLoader: ModuleLoader | undefined;
2626
/**
2727
* Global options
2828
*/
29-
const loaderOptions: ModuleLoaderOptions = {
29+
const loaderOptions: ModuleLoaderOptions<any> = {
3030
sync: false,
3131
};
3232

@@ -58,7 +58,7 @@ export const getActiveLoader = () => (getCurrentInstance() && inject(ModuleLoade
5858
* Set ModuleLoader options
5959
* @param options Options
6060
*/
61-
export function setOptions(options: ModuleLoaderOptions) {
61+
export function setOptions<Props extends Record<string, any>>(options: ModuleLoaderOptions<Props>) {
6262
Object.assign(loaderOptions, options);
6363
}
6464

@@ -154,7 +154,7 @@ export function registerSubModules(config: RegistrableModule | RegistrableModule
154154
/**
155155
* Start module loader
156156
*/
157-
start: (options?: Pick<ModuleLoaderOptions, 'loading' | 'register'> & { router?: Router }) =>
157+
start: (options?: Pick<ModuleLoaderOptions<any>, 'loading' | 'register'> & { router?: Router }) =>
158158
execute(loader!._moduleLoader, subModuleConfigs, Object.assign({}, loaderOptions, options), loader!._a),
159159
};
160160

@@ -168,7 +168,7 @@ export function registerSubModules(config: RegistrableModule | RegistrableModule
168168
async function execute(
169169
moduleLoader: ModuleLoader['_moduleLoader'],
170170
subModuleConfigs: InnerRegisterSubModule[],
171-
options: ModuleLoaderOptions & { router?: Router },
171+
options: ModuleLoaderOptions<any> & { router?: Router },
172172
app?: App,
173173
) {
174174
// 加载模块

packages/module-loader/src/types.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
import type { App, Vue2, Component } from 'vue-demi';
22

3-
export interface ModuleLoader<Props extends Record<string, any> = {}, Context = any> {
3+
export interface ModuleLoader<Props extends Record<string, any> = any, Context = any> {
44
/**
55
* Alias of export setModuleLoaderOptions
66
*/
7-
setOptions: (options: ModuleLoaderOptions<Props>) => ModuleLoader;
7+
setOptions: (options: ModuleLoaderOptions<Props>) => ModuleLoader<Props, Context>;
88
/**
99
* Alias of export addErrorHandler
1010
*/
11-
addErrorHandler: (handler: ErrorHandler) => ModuleLoader;
11+
addErrorHandler: (handler: ErrorHandler) => ModuleLoader<Props, Context>;
1212
/**
1313
* Alias of export removeErrorHandler
1414
*/
15-
removeErrorHandler: (handler: ErrorHandler) => ModuleLoader;
15+
removeErrorHandler: (handler: ErrorHandler) => ModuleLoader<Props, Context>;
1616
/**
1717
* Resolver
1818
*/
@@ -57,7 +57,7 @@ export interface RegisterProperties {
5757
/**
5858
* Main module loader typings
5959
*/
60-
export type ModuleLoaderOptions<Props extends Record<string, any> = {}> = {
60+
export type ModuleLoaderOptions<Props extends Record<string, any>> = {
6161
/**
6262
* Use sync mode to load submodules
6363
* @default false

0 commit comments

Comments
 (0)