Skip to content

Conversation

@essapp
Copy link

@essapp essapp commented Dec 2, 2025

fixes #22487
After inspection, it was found that, apart from spelling errors, jsob did not handle the style changes introduced in helidon v4 as jackson did.
1.Correct the spelling errors and handle the jsonb data in the same way as described by jackson.

io.helidon.http.media
helidon-http1media-jsonb
io.helidon.{{^x-helidon-v3}}http.{{/x-helidon-v3}}media
helidon-{{^x-helidon-v3}}http-{{/x-helidon-v3}}jsonb

2.Refer to the "jackson" method to perform corresponding processing on other referenced jsonb data.
Currently, Helidon officially supports three versions: V2, V3, and V4. After analysis, the current way of Jackson handling the changes in V4 style has some flaws. When using the V2 version, there are bugs and not all affected areas have been properly addressed. Due to the heavy workload, we will first make corrections using the original method, and then allocate more time for optimization later.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Description A bug occurred. When using the jsonb parameter, in the java-helidon-client

2 participants