Added Vector3Utils.ceil test. Fixed up AABBUtils tests to use toEqual since Vector3Utils.equals requires an extra helper to stringify the expected/actual inputs

Author: sweetniamhy

libraries/math/src/aabb/coreHelpers.test.ts

@@ -9,13 +9,6 @@ import type { Vector3 } from '@minecraft/server';
 import { VECTOR3_FORWARD, VECTOR3_ONE, VECTOR3_ZERO, Vector3Utils } from '../vector3/coreHelpers.js';
 import { AABB, AABBUtils } from './coreHelpers.js';
 
-function expectVector3(expected: Vector3, actual: Vector3) {
-    return expect(
-        Vector3Utils.equals(expected, actual),
-        `Expected ${Vector3Utils.toString(expected)} but actual is ${Vector3Utils.toString(actual)}`
-    );
-}
-
 describe('AABB factories', () => {
     it('successfully reports invalid AABB when created from identical corner points', () => {
         const aabb = AABBUtils.createFromCornerPoints(VECTOR3_ONE, VECTOR3_ONE);
@@ -165,42 +158,42 @@ describe('AABB BlockVolume operations', () => {
     it('successfully creates a BlockVolume when AABB extents are VECTOR3_ONE', () => {
         const aabb: AABB = { center: VECTOR3_ZERO, extents: VECTOR3_ONE };
         const blockVolume = AABBUtils.getBlockVolume(aabb);
-        expectVector3({ x: -1.0, y: -1.0, z: -1.0 }, blockVolume.from).toBe(true);
-        expectVector3({ x: 1.0, y: 1.0, z: 1.0 }, blockVolume.to).toBe(true);
+        expect(blockVolume.from).toEqual({ x: -1.0, y: -1.0, z: -1.0 });
+        expect(blockVolume.to).toEqual({ x: 1.0, y: 1.0, z: 1.0 });
     });
 
     it('successfully creates a BlockVolume when AABB extents coords are 0.5', () => {
         const aabb: AABB = { center: VECTOR3_ZERO, extents: { x: 0.5, y: 0.5, z: 0.5 } };
         const blockVolume = AABBUtils.getBlockVolume(aabb);
-        expectVector3({ x: -1.0, y: -1.0, z: -1.0 }, blockVolume.from).toBe(true);
-        expectVector3({ x: 1.0, y: 1.0, z: 1.0 }, blockVolume.to).toBe(true);
+        expect(blockVolume.from).toEqual({ x: -1.0, y: -1.0, z: -1.0 });
+        expect(blockVolume.to).toEqual({ x: 1.0, y: 1.0, z: 1.0 });
     });
 
     it('successfully creates a BlockVolume when AABB center and extent coords are 0.5', () => {
         const aabb: AABB = { center: { x: 0.5, y: 0.5, z: 0.5 }, extents: { x: 0.5, y: 0.5, z: 0.5 } };
         const blockVolume = AABBUtils.getBlockVolume(aabb);
-        expectVector3({ x: 0.0, y: 0.0, z: 0.0 }, blockVolume.from).toBe(true);
-        expectVector3({ x: 1.0, y: 1.0, z: 1.0 }, blockVolume.to).toBe(true);
+        expect(blockVolume.from).toEqual({ x: 0.0, y: 0.0, z: 0.0 });
+        expect(blockVolume.to).toEqual({ x: 1.0, y: 1.0, z: 1.0 });
     });
 
     it('successfully creates a BlockVolume when AABB center coords are -0.5 and extent coords are 0.5', () => {
         const aabb: AABB = { center: { x: -0.5, y: -0.5, z: -0.5 }, extents: { x: 0.5, y: 0.5, z: 0.5 } };
         const blockVolume = AABBUtils.getBlockVolume(aabb);
-        expectVector3({ x: -1.0, y: -1.0, z: -1.0 }, blockVolume.from).toBe(true);
-        expectVector3({ x: 0.0, y: 0.0, z: 0.0 }, blockVolume.to).toBe(true);
+        expect(blockVolume.from).toEqual({ x: -1.0, y: -1.0, z: -1.0 });
+        expect(blockVolume.to).toEqual({ x: -0.0, y: -0.0, z: -0.0 });
     });
 
     it('successfully creates a BlockVolume when AABB extents are greater than VECTOR3_ZERO within epsilon', () => {
         const aabb: AABB = { center: VECTOR3_ZERO, extents: { x: 0.00001, y: 0.00001, z: 0.00001 } };
         const blockVolume = AABBUtils.getBlockVolume(aabb);
-        expectVector3({ x: 0.0, y: 0.0, z: 0.0 }, blockVolume.from).toBe(true);
-        expectVector3({ x: 0.0, y: 0.0, z: 0.0 }, blockVolume.to).toBe(true);
+        expect(blockVolume.from).toEqual({ x: 0.0, y: 0.0, z: 0.0 });
+        expect(blockVolume.to).toEqual({ x: 0.0, y: 0.0, z: 0.0 });
     });
 
     it('successfully creates a BlockVolume when AABB extents are greater than VECTOR3_ZERO exceeding epsilon', () => {
         const aabb: AABB = { center: VECTOR3_ZERO, extents: { x: 0.00002, y: 0.00002, z: 0.00002 } };
         const blockVolume = AABBUtils.getBlockVolume(aabb);
-        expectVector3({ x: -1.0, y: -1.0, z: -1.0 }, blockVolume.from).toBe(true);
-        expectVector3({ x: 1.0, y: 1.0, z: 1.0 }, blockVolume.to).toBe(true);
+        expect(blockVolume.from).toEqual({ x: -1.0, y: -1.0, z: -1.0 });
+        expect(blockVolume.to).toEqual({ x: 1.0, y: 1.0, z: 1.0 });
     });
 });

libraries/math/src/vector3/coreHelpers.test.ts

@@ -88,6 +88,18 @@ describe('Vector3 operations', () => {
         expect(Vector3Utils.floor(input)).toEqual(expected);
     });
 
+    it('computes the ceil of the vector', () => {
+        const input: Vector3 = { x: 0.33, y: 1.14, z: 2.55 };
+        const expected: Vector3 = { x: 1, y: 2, z: 3 };
+        expect(Vector3Utils.ceil(input)).toEqual(expected);
+    });
+
+    it('computes the ceil of negative vectors', () => {
+        const input: Vector3 = { x: -0.33, y: -1.14, z: -2.55 };
+        const expected: Vector3 = { x: -0, y: -1, z: -2 };
+        expect(Vector3Utils.ceil(input)).toEqual(expected);
+    });
+
     it('normalizes the vector', () => {
         const result: Vector3 = Vector3Utils.normalize(v1);
         expect(result.x).toBeCloseTo(0.27, 2);