Skip to content

Conversation

@Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Nov 7, 2025

@mbabker
Copy link
Contributor

mbabker commented Nov 20, 2025

i am not sure, how to rewrite https://github.com/FriendsOfSymfony/FOSCKEditorBundle/blob/2.x/src/Resources/config/renderer.xml#L14C65-L14C71

IIRC it's something like expr("container.hasParameter('locale') ? parameter('locale') : null")

@Chris53897
Copy link
Contributor Author

thanks @mbabker
The CI is green with your suggestion and with NULL.
So i can not be 100% sure if it is correct.

Copy link
Contributor

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expression is correct.

@Chris53897
Copy link
Contributor Author

@XWB Maybe you have time to have a look.
After this is merged, symfony 8 support can be added in a seperate PR.

@XWB XWB merged commit 16ea17e into FriendsOfSymfony:2.x Dec 4, 2025
7 checks passed
@XWB
Copy link
Member

XWB commented Dec 4, 2025

👍 Thank you

@Chris53897 Chris53897 deleted the feature/migrate-config branch December 5, 2025 10:29
@Chris53897
Copy link
Contributor Author

Thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants