-
Notifications
You must be signed in to change notification settings - Fork 412
Ensure headers are in sentence case except for product names #4921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
|
Co-authored-by: Blargian <[email protected]>
Blargian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot take a look at the exception list in https://github.com/ClickHouse/clickhouse-docs/blob/main/styles/ClickHouse/Headings.yml for which words you don't need to make lower-case. There are quite a few instances here where you have made "Cloud" into "cloud" or "ClickHouse Private" into "ClickHouse private" when these are product names. Please address these issues.
contribute/contrib-writing-guide.md
Outdated
| Note: in the examples below you may notice that the H1 and H2 headers are outside of the tabs, the right-side "What's on this page" nav is built from the H1,2,3 headers in the main body of the markdown file, headings within the tabs are not currently included. | ||
|
|
||
| ### Differences between Cloud and Self-managed {#differences-between-cloud-and-self-managed} | ||
| ### Differences between cloud and Self-managed {#differences-between-cloud-and-self-managed} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot here Cloud is a product (ClickHouse Cloud) and so it should be capitalised. You can make "Self-managed" lower-case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit faf7139. Changed "cloud and Self-managed" to "Cloud and self-managed".
contribute/style-guide.md
Outdated
| ``` | ||
|
|
||
| ### Associated markdown rule or CI check | ||
| ### Associated Markdown rule or ci check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot "Markdown" should be lowercase, and "ci" is an acronym so it should remain CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit faf7139. Changed "Markdown rule or ci check" to "markdown rule or CI check".
contribute/style-guide.md
Outdated
| ``` | ||
|
|
||
| ### Associated markdown rule or CI check | ||
| ### Associated Markdown rule or ci check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Associated Markdown rule or ci check | |
| ### Associated markdown rule or CI check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit faf7139.
| <summary>Create GCS buckets and an HMAC key</summary> | ||
|
|
||
| ### ch_bucket_us_east1 {#ch_bucket_us_east1} | ||
| ### Ch_bucket_us_east1 {#ch_bucket_us_east1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Ch_bucket_us_east1 {#ch_bucket_us_east1} | |
| ### ch_bucket_us_east1 {#ch_bucket_us_east1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit faf7139.
| <Image size="md" img={GCS_bucket_1} alt="Creating a GCS bucket in US East 1" border /> | ||
|
|
||
| ### ch_bucket_us_east4 {#ch_bucket_us_east4} | ||
| ### Ch_bucket_us_east4 {#ch_bucket_us_east4} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Ch_bucket_us_east4 {#ch_bucket_us_east4} | |
| ### ch_bucket_us_east4 {#ch_bucket_us_east4} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit faf7139.
| ## CPU {#cpu} | ||
|
|
||
| ### Which CPU should I use? {#which-cpu-should-i-use} | ||
| ### Which CPU should i use? {#which-cpu-should-i-use} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
singular "i" should be capitalised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit faf7139. Changed "Which CPU should i use?" to "Which CPU should I use?".
| To provide guidance (not recommendations), the following are example configurations of ClickHouse users in production: | ||
|
|
||
| ### Fortune 500 B2B SaaS {#fortune-500-b2b-saas} | ||
| ### Fortune 500 b2b saas {#fortune-500-b2b-saas} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Fortune 500 b2b saas {#fortune-500-b2b-saas} | |
| ### Fortune 500 B2B SaaS {#fortune-500-b2b-saas} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit faf7139. Changed to "Fortune 500 B2B SaaS".
| For examples of refreshable materialized views see [here](/materialized-view/refreshable-materialized-view). | ||
|
|
||
| ### APPEND vs REPLACE mode {#append-vs-replace-mode} | ||
| ### Append vs replace mode {#append-vs-replace-mode} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Append vs replace mode {#append-vs-replace-mode} | |
| ### APPEND vs REPLACE mode {#append-vs-replace-mode} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit faf7139. Changed to "APPEND vs REPLACE mode".
docs/chdb/install/bun.md
Outdated
| --- | ||
|
|
||
| # chDB for Bun | ||
| # chDB for bun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # chDB for bun | |
| # chDB for Bun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit faf7139. Changed to "chDB for Bun".
| Learn more about [ClickHouse Cloud](/getting-started/quick-start/cloud). | ||
|
|
||
| ## Bring Your Own Cloud {#byoc} | ||
| ## Bring your own cloud {#byoc} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## Bring your own cloud {#byoc} | |
| ## Bring Your Own Cloud (BYOC) {#byoc} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit faf7139. Changed to "Bring Your Own Cloud (BYOC)".
Co-authored-by: Blargian <[email protected]>
Fixed in commit faf7139. I've corrected all instances where product names like "ClickHouse Cloud", "ClickHouse Private", "Grafana Cloud", "IBM Cloud", and "Google Cloud" were incorrectly lowercased. Also fixed acronyms like CI, HMAC, IAM, LZ4, ZSTD, B2B, SaaS, BYOC, and preserved special terms like Bun and bucket names (ch_bucket_us_east1, ch_bucket_us_east4). |
Summary
This PR converts headers from Title Case to sentence case throughout the documentation, while preserving capitalization for product names, company names, and proper nouns as defined in the Vale style guide exceptions list (
styles/ClickHouse/Headings.yml).Changes made:
Examples of conversions:
The conversion follows the Vale style guide rule for sentence-case headings while maintaining proper capitalization for all product names, technical acronyms, and proper nouns.
Checklist
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.